Skip to content

Commit 6fe9854

Browse files
author
Divang Sharma
committed
Hanlded review comment: removed JSON type in Textual category and precision setting in parseQueryMeta
1 parent 9bf9ffa commit 6fe9854

File tree

2 files changed

+1
-3
lines changed

2 files changed

+1
-3
lines changed

src/main/java/com/microsoft/sqlserver/jdbc/DataTypes.java

+1-1
Original file line numberDiff line numberDiff line change
@@ -985,7 +985,7 @@ boolean isBinary() {
985985
* @return true if the JDBC type is textual
986986
*/
987987
private final static EnumSet<Category> textualCategories = EnumSet.of(Category.CHARACTER, Category.LONG_CHARACTER,
988-
Category.CLOB, Category.NCHARACTER, Category.LONG_NCHARACTER, Category.NCLOB, Category.JSON); //FIXME: JSON is textual?
988+
Category.CLOB, Category.NCHARACTER, Category.LONG_NCHARACTER, Category.NCLOB);
989989

990990
boolean isTextual() {
991991
return textualCategories.contains(category);

src/main/java/com/microsoft/sqlserver/jdbc/SQLServerParameterMetaData.java

-2
Original file line numberDiff line numberDiff line change
@@ -166,8 +166,6 @@ private void parseQueryMeta(ResultSet rsQueryMeta) throws SQLServerException {
166166
qm.precision = 8;
167167
} else if (SSType.XML == ssType) {
168168
qm.precision = SQLServerDatabaseMetaData.MAXLOBSIZE / 2;
169-
} else if (SSType.JSON == ssType) {
170-
qm.precision = SQLServerDatabaseMetaData.MAXLOBSIZE / 2;
171169
}
172170

173171
qm.parameterTypeName = ssType.toString();

0 commit comments

Comments
 (0)