-
Notifications
You must be signed in to change notification settings - Fork 435
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
JSON datatype support #2558
base: main
Are you sure you want to change the base?
JSON datatype support #2558
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #2558 +/- ##
============================================
- Coverage 51.01% 50.09% -0.93%
+ Complexity 3921 3829 -92
============================================
Files 147 147
Lines 33483 33544 +61
Branches 5609 5619 +10
============================================
- Hits 17081 16803 -278
- Misses 13991 14347 +356
+ Partials 2411 2394 -17 ☔ View full report in Codecov by Sentry. |
src/test/java/com/microsoft/sqlserver/jdbc/unit/statement/RegressionTest.java
Show resolved
Hide resolved
/azp run public-mssql-jdbc.windows |
Azure Pipelines successfully started running 1 pipeline(s). |
No pipelines are associated with this pull request. |
/azp run public-mssql-jdbc.linux |
/azp run CI-MacOS |
Azure Pipelines successfully started running 1 pipeline(s). |
1 similar comment
Azure Pipelines successfully started running 1 pipeline(s). |
src/test/java/com/microsoft/sqlserver/jdbc/callablestatement/CallableStatementTest.java
Outdated
Show resolved
Hide resolved
…m/microsoft/mssql-jdbc into user/divang/json-datatype-support
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Copilot reviewed 11 out of 26 changed files in this pull request and generated no comments.
Files not reviewed (15)
- src/main/java/com/microsoft/sqlserver/jdbc/SQLServerResource.java: Evaluated as low risk
- src/main/java/com/microsoft/sqlserver/jdbc/Parameter.java: Evaluated as low risk
- src/test/java/com/microsoft/sqlserver/jdbc/bulkCopy/BulkCopyCSVTest.java: Evaluated as low risk
- src/main/java/com/microsoft/sqlserver/jdbc/SQLServerDataTable.java: Evaluated as low risk
- src/main/java/com/microsoft/sqlserver/jdbc/Column.java: Evaluated as low risk
- src/main/java/com/microsoft/sqlserver/jdbc/SQLServerBulkCopy.java: Evaluated as low risk
- src/main/java/com/microsoft/sqlserver/jdbc/IOBuffer.java: Evaluated as low risk
- src/main/java/com/microsoft/sqlserver/jdbc/SQLServerResultSetMetaData.java: Evaluated as low risk
- src/main/java/com/microsoft/sqlserver/jdbc/DataTypes.java: Evaluated as low risk
- src/test/java/com/microsoft/sqlserver/jdbc/bulkCopy/SqlTypeMapping.java: Evaluated as low risk
- src/main/java/com/microsoft/sqlserver/jdbc/SQLServerConnection.java: Evaluated as low risk
- src/main/java/microsoft/sql/Types.java: Evaluated as low risk
- src/main/java/com/microsoft/sqlserver/jdbc/dtv.java: Evaluated as low risk
- src/test/java/com/microsoft/sqlserver/jdbc/callablestatement/CallableStatementTest.java: Evaluated as low risk
- src/test/java/com/microsoft/sqlserver/jdbc/tvp/TVPTypesTest.java: Evaluated as low risk
…using the column label instead of the index.
src/test/java/com/microsoft/sqlserver/jdbc/JSONFunctionTest.java
Outdated
Show resolved
Hide resolved
src/main/java/com/microsoft/sqlserver/jdbc/SQLServerBulkCSVFileRecord.java
Outdated
Show resolved
Hide resolved
…otes, preventing misclassification of non-JSON braces, and adding test cases based on review comments.
…mnNameWithJson.csv.
…al and local temporary tables, UDF with SELECT, WHERE, and FROM clauses, and SELECT INTO queries.
…ata check, direct function call validation, and assertion for JSON structure.
…BulkCopy=true in connection string
To add support for the new JSON datatype, the following changes have been made to the codebase: