Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixed issue for IBM Semeru Runtime Certified Edition for z/OS and Kerberos #2581

Merged
merged 12 commits into from
Feb 11, 2025
Merged

Fixed issue for IBM Semeru Runtime Certified Edition for z/OS and Kerberos #2581

merged 12 commits into from
Feb 11, 2025

Conversation

muskan124947
Copy link
Contributor

@muskan124947 muskan124947 commented Jan 10, 2025 •
edited
Loading

Github Issue: #2576

@muskan124947 muskan124947 self-assigned this Jan 10, 2025
@machavan machavan linked an issue Jan 13, 2025 that may be closed by this pull request
IBM Semeru Runtime Certified Edition for z/OS, Kerberos and mssql-jdbc don't work together #2576
Closed
@muskan124947
Copy link
Contributor Author

/azp run public-mssql-jdbc.windows

@azure-pipelines Azure Pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@muskan124947
Copy link
Contributor Author

/azp run public-mssql-jdbc.linux

@azure-pipelines Azure Pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@muskan124947
Copy link
Contributor Author

/azp run CI-MacOS

@azure-pipelines Azure Pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@codecov Codecov
Copy link

codecov bot commented Jan 15, 2025 •
edited
Loading

Codecov Report

Attention: Patch coverage is 21.42857% with 22 lines in your changes missing coverage. Please review.

Project coverage is 51.46%. Comparing base (25ea8da) to head (bab60c7).
Report is 3 commits behind head on main.

Files with missing lines Patch % Lines
...om/microsoft/sqlserver/jdbc/JaasConfiguration.java 0.00% 12 Missing ⚠️
...c/main/java/com/microsoft/sqlserver/jdbc/Util.java 50.00% 5 Missing and 1 partial ⚠️
...m/microsoft/sqlserver/jdbc/KerbAuthentication.java 0.00% 4 Missing ⚠️
Additional details and impacted files 
@@             Coverage Diff              @@
##               main    #2581      +/-   ##
============================================
+ Coverage     51.35%   51.46%   +0.11%     
- Complexity     3972     4016      +44     
============================================
  Files           147      147              
  Lines         33664    33685      +21     
  Branches       5626     5626              
============================================
+ Hits          17288    17336      +48     
- Misses        13939    13960      +21     
+ Partials       2437     2389      -48

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

machavan
machavan previously approved these changes Jan 16, 2025
View reviewed changes
Copy link
Contributor

@machavan machavan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please run

  • azp run
    -ADO tests with this branch

@muskan124947
Copy link
Contributor Author

/azp run public-mssql-jdbc.linux

@azure-pipelines Azure Pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@muskan124947
Copy link
Contributor Author

tested with ado pipeline
https://sqlclientdrivers.visualstudio.com/mssql-jdbc/_build/results?buildId=105806&view=results

@muskan124947 muskan124947 marked this pull request as draft January 23, 2025 04:21
@muskan124947 muskan124947 marked this pull request as ready for review January 24, 2025 09:01
@muskan124947 muskan124947 merged commit e63814e into main Feb 11, 2025
18 of 19 checks passed
@muskan124947 muskan124947 deleted the users/muskgupta/githubIssue#2576 branch February 11, 2025 10:51
@lilgreenbird lilgreenbird added this to the 12.10.0 milestone Feb 12, 2025
@muskan124947 muskan124947 restored the users/muskgupta/githubIssue#2576 branch February 12, 2025 04:44
@Jeffery-Wasty Jeffery-Wasty deleted the users/muskgupta/githubIssue#2576 branch February 12, 2025 20:03
@lilgreenbird lilgreenbird changed the title IBM Semeru Runtime Certified Edition for z/OS, Kerberos and mssql-jdbc don't work together #2576 Fixed issue for IBM Semeru Runtime Certified Edition for z/OS and Kerberos Mar 4, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lilgreenbird lilgreenbird lilgreenbird left review comments

@David-Engel David-Engel David-Engel left review comments

@divang divang divang approved these changes

@machavan machavan machavan approved these changes

@Jeffery-Wasty Jeffery-Wasty Awaiting requested review from Jeffery-Wasty

@tkyc tkyc Awaiting requested review from tkyc

@codewatchzen codewatchzen Awaiting requested review from codewatchzen

Assignees

@muskan124947 muskan124947

Labels
None yet
Projects
MSSQL JDBC
Status: Closed/Merged PRs
Milestone
12.10.0
Development

Successfully merging this pull request may close these issues.

IBM Semeru Runtime Certified Edition for z/OS, Kerberos and mssql-jdbc don't work together
5 participants
@muskan124947 @lilgreenbird @divang @David-Engel @machavan