Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added com.ibm.security.auth.module and com.sun.security.auth.module as option import #2609

Merged
merged 1 commit into from
Feb 18, 2025
Merged

Added com.ibm.security.auth.module and com.sun.security.auth.module as option import #2609

merged 1 commit into from
Feb 18, 2025

Conversation

muskan124947
Copy link
Contributor

Github Issue: #2608

@muskan124947 muskan124947 self-assigned this Feb 18, 2025
@codecov Codecov
Copy link

codecov bot commented Feb 18, 2025 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 51.47%. Comparing base (e63814e) to head (4ef79d6).
Report is 1 commits behind head on main.

Additional details and impacted files 
@@             Coverage Diff              @@
##               main    #2609      +/-   ##
============================================
+ Coverage     51.35%   51.47%   +0.11%     
- Complexity     3981     4000      +19     
============================================
  Files           147      147              
  Lines         33686    33686              
  Branches       5627     5627              
============================================
+ Hits          17300    17340      +40     
+ Misses        13956    13927      -29     
+ Partials       2430     2419      -11

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@machavan machavan linked an issue Feb 18, 2025 that may be closed by this pull request
Mandatory OSGi-imports rg. com.ibm.security.auth.module fail deployments #2608
Closed
@machavan machavan mentioned this pull request Feb 18, 2025
Open
MrEasy
MrEasy approved these changes Feb 18, 2025
View reviewed changes
Copy link
Contributor

@MrEasy MrEasy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

tested build - import declarations created as optional - lgtm

@muskan124947
Copy link
Contributor Author

ADO pipeline: https://sqlclientdrivers.visualstudio.com/mssql-jdbc/_build/results?buildId=108913&view=results

@muskan124947 muskan124947 reopened this Feb 18, 2025
@muskan124947 muskan124947 merged commit 4a0a7bc into main Feb 18, 2025
22 checks passed
@Jeffery-Wasty Jeffery-Wasty deleted the users/muskgupta/issue#2608 branch February 18, 2025 18:54
@lilgreenbird lilgreenbird added this to the 12.10.0 milestone Mar 4, 2025
@lilgreenbird lilgreenbird changed the title Add com.ibm.security.auth.module and com.sun.security.auth.module as option import Added com.ibm.security.auth.module and com.sun.security.auth.module as option import Mar 4, 2025
@Jeffery-Wasty Jeffery-Wasty mentioned this pull request Mar 4, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MrEasy MrEasy MrEasy approved these changes

@divang divang divang approved these changes

@machavan machavan machavan approved these changes

@lilgreenbird lilgreenbird Awaiting requested review from lilgreenbird

@Jeffery-Wasty Jeffery-Wasty Awaiting requested review from Jeffery-Wasty

@tkyc tkyc Awaiting requested review from tkyc

Assignees

@muskan124947 muskan124947

Labels
None yet
Projects
MSSQL JDBC
Status: Closed/Merged PRs
Milestone
12.10.0
Development

Successfully merging this pull request may close these issues.

Mandatory OSGi-imports rg. com.ibm.security.auth.module fail deployments
5 participants
@muskan124947 @MrEasy @divang @machavan @lilgreenbird