vmbus_client: take over synic handling from the relay #899
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Copilot reviewed 7 out of 16 changed files in this pull request and generated no comments.
Files not reviewed (9)
- openhcl/underhill_core/src/worker.rs: Evaluated as low risk
- vm/devices/vmbus/vmbus_core/src/protocol.rs: Evaluated as low risk
- vm/devices/vmbus/vmbus_client/Cargo.toml: Evaluated as low risk
- vm/devices/vmbus/vmbus_server/src/channels/saved_state.rs: Evaluated as low risk
- vm/devices/vmbus/vmbus_relay_intercept_device/src/lib.rs: Evaluated as low risk
- vm/devices/vmbus/vmbus_relay/Cargo.toml: Evaluated as low risk
- vm/devices/vmbus/vmbus_server/src/channels.rs: Evaluated as low risk
- support/inspect/src/lib.rs: Evaluated as low risk
- support/mesh/mesh_channel/src/rpc.rs: Evaluated as low risk
Comments suppressed due to low confidence (2)
vm/devices/vmbus/vmbus_relay/src/lib.rs:269
- Ensure that the new behavior for handling interrupts using
PolledNotifyis covered by tests, especially the scenarios where interrupts are relayed and the guest-to-host interrupt handling.
async fn handle_open_channel(&mut self, open_request: &OpenRequest) -> Result<OpenResult> {
vm/devices/vmbus/vmbus_client/src/saved_state.rs:142
- The new
handle_post_restorefunction introduces behavior that should be covered by tests to ensure unclaimed channels are correctly closed and their GPADLs are torn down.
pub fn handle_post_restore(&mut self) {
chris-oo
reviewed
Feb 25, 2025
| open_data.connection_id | ||
| }; | ||
|
|
||
| // No failure paths after this point, since otherwise we would need to |
There was a problem hiding this comment.
Err... what does this comment mean, when i see a failed rpc below? Do you mean after event flag allocation?
chris-oo
previously approved these changes
Feb 25, 2025
Don't leak the synic details into `vmbus_relay` or `vmbus_relay_intercept_device`. This will make it easier to use `vmbus_client` without `vmbus_relay` in future changes.
jstarks
force-pushed
the
more_vmbus_client_cleanup
branch
from
c36522e to
05257e0
Compare
SvenGroot
reviewed
Feb 27, 2025
| @@ -4266,9 +4252,10 @@ mod tests { | |||
| open_channel, | |||
| event_flag: 2, | |||
| connection_id: 0x2002, | |||
| flags: u16::from( | |||
| flags: (u16::from( | |||
There was a problem hiding this comment.
Minor: I've started preferring flags.into_bits() instead of u16::from(flags) (or whatever type) as I feel it's more readable.
SvenGroot
approved these changes
Feb 27, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Don't leak the synic details into
vmbus_relayorvmbus_relay_intercept_device. This will make it easier to usevmbus_clientwithoutvmbus_relayin future changes.