Skip to content

Commit ed94ad1

Browse files
committed
fix: make sure Playwright works in DevContainers
This patch fixes Invalid browser name exception when Playwright is used in a DevContainer context Fixes #3174
1 parent 2515ebc commit ed94ad1

File tree

1 file changed

+2
-3
lines changed

1 file changed

+2
-3
lines changed

src/Playwright.TestAdapter/PlaywrightSettingsProvider.cs

Lines changed: 2 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -40,9 +40,8 @@ public static string BrowserName
4040
get
4141
{
4242
var browserFromEnv = Environment.GetEnvironmentVariable("BROWSER")?.ToLowerInvariant();
43-
// GitHub Codespaces sets the BROWSER environment variable, ignore it if its bogus.
44-
var ignoreValueFromEnv = Environment.GetEnvironmentVariable("CODESPACES") == "true" && browserFromEnv!.StartsWith("/vscode/");
45-
if (!string.IsNullOrEmpty(browserFromEnv) && !ignoreValueFromEnv)
43+
// GitHub Codespaces and DevContainers sets the BROWSER environment variable, ignore it if its bogus.
44+
if (!string.IsNullOrEmpty(browserFromEnv) && !browserFromEnv!.StartsWith("/vscode/"))
4645
{
4746
ValidateBrowserName(browserFromEnv!, "'BROWSER' environment variable", "\nTry to remove 'BROWSER' environment variable for using default browser");
4847
return browserFromEnv!;

0 commit comments

Comments
 (0)