fix: make sure Playwright works in DevContainers #3181
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This patch fixes Invalid browser name exception when Playwright is used in a DevContainer context Fixes microsoft#3174
CurlyFire
force-pushed
the
fix-invalid-browser-devcontainers
branch
from
43c2acb to
ed94ad1
Compare
|
@mxschmitt I completed the modification after understanding how all the tests and checks work. However, when I commented out the thrown exception in the ValidateBrowserName method, not a single test that I ran locally failed. I thought that there would be a test that checked this behavior, so that I could modify it. I would add one, but I'm not 100% certain what the context of the test should be or if I should even add one for this. |
mxschmitt
approved these changes
May 29, 2025
|
We don't have any tests for that - I think we can land as it is? |
|
@mxschmitt Yep, sounds good |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This patch fixes Invalid browser name exception when Playwright is used in a DevContainer context
Fixes #3174