fix: report not valid browser names as error (#3)

Author: mxschmitt

README.md

@@ -23,11 +23,10 @@ pip install pytest-playwright
 Basic example for more see the [examples sections](#examples) as a reference.
 
 ```py
-def test_is_chromium(page):
-    page.goto("https://www.google.com")
-    page.type("input[name=q]", "Playwright GitHub")
-    page.click("input[type=submit]")
-    page.waitForSelector("text=microsoft/Playwright")
+def test_example_is_working(page):
+    page.goto("https://example.com")
+    page.waitForSelector("text=Example Domain")
+    page.click("text=More information")
 ```
 
 ## Fixtures
@@ -80,8 +79,8 @@ By default, the tests run in headless mode. You can pass the `--headful` CLI fla
 import pytest
 
 @pytest.mark.skip_browser("firefox")
-def test_is_chromium(page):
-    page.goto("https://www.google.com")
+def test_visit_example(page):
+    page.goto("https://example.com")
     # ...
 ```
 
@@ -91,8 +90,8 @@ def test_is_chromium(page):
 import pytest
 
 @pytest.mark.only_browser("chromium")
-def test_is_chromium(page):
-    page.goto("https://www.google.com")
+def test_visit_example(page):
+    page.goto("https://example.com")
     # ...
 ```
 
@@ -101,7 +100,7 @@ def test_is_chromium(page):
 Start Pytest with the `base-url` argument. Example: `pytest --base-url http://localhost:8080`
 
 ```py
-def test_is_chromium(page):
+def test_visit_example(page):
     page.goto("/admin")
     # -> Will result in http://localhost:8080/admin
 ```
@@ -111,7 +110,7 @@ def test_is_chromium(page):
 ```py
 from playwright.sync_api import Page
 
-def test_my_test(page: Page):
+def test_visit_admin_dashboard(page: Page):
     page.goto("/admin")
     # ...
 ```
@@ -132,4 +131,4 @@ provided by the bot. You will only need to do this once across all repos using o
 
 This project has adopted the [Microsoft Open Source Code of Conduct](https://opensource.microsoft.com/codeofconduct/).
 For more information see the [Code of Conduct FAQ](https://opensource.microsoft.com/codeofconduct/faq/) or
-contact [opencode@microsoft.com](mailto:opencode@microsoft.com) with any additional questions or comments.
+contact [opencode@microsoft.com](mailto:opencode@microsoft.com) with any additional questions or comments.

setup.py

@@ -13,7 +13,7 @@
     url="https://github.com/microsoft/playwright-pytest",
     packages=["pytest_playwright"],
     include_package_data=True,
-    install_requires=["playwright==0.0.4", "pytest", "pytest-base-url"],
+    install_requires=["playwright>=0.0.4", "pytest", "pytest-base-url"],
     entry_points={"pytest11": ["playwright = pytest_playwright.pytest_playwright"]},
     classifiers=[
         "Programming Language :: Python :: 3",

tests/test_playwright.py

@@ -115,8 +115,8 @@ def test_base_url(page, base_url):
             assert base_url == "https://example.com"
             page.goto("/foobar")
             assert page.url == "https://example.com/foobar"
-            page.goto("https://www.google.com")
-            assert page.url == "https://www.google.com/"
+            page.goto("http://whatsmyuseragent.org")
+            assert page.url == "http://whatsmyuseragent.org/"
     """
     )
     result = testdir.runpytest("--base-url", "https://example.com")