Skip to content

Commit e6c5ba4

Browse files
authored
devops: add linux-arm64 Docker tests (#2837)
1 parent fe886f7 commit e6c5ba4

File tree

2 files changed

+8
-30
lines changed

2 files changed

+8
-30
lines changed

.github/workflows/test_docker.yml

Lines changed: 8 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -19,13 +19,16 @@ on:
1919
jobs:
2020
build:
2121
timeout-minutes: 120
22-
runs-on: ubuntu-24.04
22+
runs-on: ${{ matrix.runs-on }}
2323
strategy:
2424
fail-fast: false
2525
matrix:
2626
docker-image-variant:
2727
- jammy
2828
- noble
29+
runs-on:
30+
- ubuntu-24.04
31+
- ubuntu-24.04-arm
2932
steps:
3033
- uses: actions/checkout@v4
3134
- name: Set up Python
@@ -39,10 +42,12 @@ jobs:
3942
pip install -r requirements.txt
4043
pip install -e .
4144
- name: Build Docker image
42-
run: bash utils/docker/build.sh --amd64 ${{ matrix.docker-image-variant }} playwright-python:localbuild-${{ matrix.docker-image-variant }}
45+
run: |
46+
ARCH="${{ matrix.runs-on == 'ubuntu-24.04-arm' && 'arm64' || 'amd64' }}"
47+
bash utils/docker/build.sh --$ARCH ${{ matrix.docker-image-variant }} playwright-python:localbuild-${{ matrix.docker-image-variant }}
4348
- name: Test
4449
run: |
45-
CONTAINER_ID="$(docker run --rm -v $(pwd):/root/playwright --name playwright-docker-test --workdir /root/playwright/ -d -t playwright-python:localbuild-${{ matrix.docker-image-variant }} /bin/bash)"
50+
CONTAINER_ID="$(docker run --rm -e CI -v $(pwd):/root/playwright --name playwright-docker-test --workdir /root/playwright/ -d -t playwright-python:localbuild-${{ matrix.docker-image-variant }} /bin/bash)"
4651
# Fix permissions for Git inside the container
4752
docker exec "${CONTAINER_ID}" chown -R root:root /root/playwright
4853
docker exec "${CONTAINER_ID}" pip install -r local-requirements.txt

.github/workflows/trigger_internal_tests.yml

Lines changed: 0 additions & 27 deletions
This file was deleted.

0 commit comments

Comments
 (0)