Skip to content

Commit 7b61900

Browse files
authored
Merge pull request #195 from asklar/colorhelper
Remove implicit dependency on ColorHelper
2 parents 678e796 + e61a544 commit 7b61900

File tree

5 files changed

+32
-4
lines changed

5 files changed

+32
-4
lines changed

package/CHANGELOG.json

Lines changed: 15 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,21 @@
11
{
22
"name": "react-native-xaml",
33
"entries": [
4+
{
5+
"date": "Wed, 13 Apr 2022 21:16:52 GMT",
6+
"tag": "react-native-xaml_v0.0.63",
7+
"version": "0.0.63",
8+
"comments": {
9+
"patch": [
10+
{
11+
"author": "asklar@microsoft.com",
12+
"package": "react-native-xaml",
13+
"comment": "Remove implicit dependency on ColorHelper",
14+
"commit": "265e4a0f46b1e00d5aaddb428384e9b4f8168b43"
15+
}
16+
]
17+
}
18+
},
419
{
520
"date": "Sun, 20 Feb 2022 03:58:46 GMT",
621
"tag": "react-native-xaml_v0.0.62",

package/CHANGELOG.md

Lines changed: 9 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,9 +1,17 @@
11
# Change Log - react-native-xaml
22

3-
This log was last generated on Sun, 20 Feb 2022 03:58:46 GMT and should not be manually modified.
3+
This log was last generated on Wed, 13 Apr 2022 21:16:52 GMT and should not be manually modified.
44

55
<!-- Start content -->
66

7+
## 0.0.63
8+
9+
Wed, 13 Apr 2022 21:16:52 GMT
10+
11+
### Patches
12+
13+
- Remove implicit dependency on ColorHelper (asklar@microsoft.com)
14+
715
## 0.0.62
816

917
Sun, 20 Feb 2022 03:58:46 GMT

package/package.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,7 @@
11
{
22
"name": "react-native-xaml",
33
"title": "React Native Xaml",
4-
"version": "0.0.62",
4+
"version": "0.0.63",
55
"description": "Allows using XAML directly, inside of a React Native Windows app",
66
"main": "lib/index.js",
77
"typings": "lib/index.d.ts",

package/windows/ReactNativeXaml/Codegen/Version.g.h

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -7,4 +7,4 @@ THIS FILE WAS AUTOMATICALLY GENERATED, DO NOT MODIFY MANUALLY
77
#define VERSION_MAJOR 0
88
#define VERSION_MINOR 0
99
#define VERSION_REVISION 0
10-
#define VERSION_BUILD 62
10+
#define VERSION_BUILD 63

package/windows/ReactNativeXaml/Styling.cpp

Lines changed: 6 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -4,6 +4,11 @@
44
/// from RNW ValueUtils.cpp
55
#pragma region Copied from RNW ValueUtils.cpp
66
namespace ColorUtils {
7+
8+
inline winrt::Windows::UI::Color FromArgb(uint8_t a, uint8_t r, uint8_t g, uint8_t b) {
9+
return winrt::Windows::UI::Color{ a, r, g, b };
10+
}
11+
712
struct ColorComp {
813
bool operator()(const winrt::Windows::UI::Color& lhs, const winrt::Windows::UI::Color& rhs) const {
914
return (
@@ -42,7 +47,7 @@ namespace ColorUtils {
4247

4348

4449
winrt::Windows::UI::Color ColorFromNumber(DWORD argb) {
45-
return winrt::ColorHelper::FromArgb(GetAFromArgb(argb), GetRFromArgb(argb), GetGFromArgb(argb), GetBFromArgb(argb));
50+
return FromArgb(GetAFromArgb(argb), GetRFromArgb(argb), GetGFromArgb(argb), GetBFromArgb(argb));
4651
}
4752

4853
winrt::Windows::UI::Color ColorFrom(const winrt::Microsoft::ReactNative::JSValue& v) {

0 commit comments

Comments
 (0)