fixes

microsoft · Jan 5, 2025 · 04322cf · 04322cf
1 parent d8ab611
commit 04322cf
Showing 1 changed file with 9 additions and 4 deletions.
diff --git a/src/kernels/jupyter/jupyterUtils.ts b/src/kernels/jupyter/jupyterUtils.ts
@@ -146,23 +146,28 @@ export function createJupyterConnectionInfo(
     const serializer: import('@jupyterlab/services').ServerConnection.ISettings['serializer'] = {
         deserialize: (data: ArrayBuffer, protocol?: string) => {
             try {
+                if (typeof data === 'string') {
+                    return deserialize(data, '');
+                }
                 return deserialize(data, protocol);
             } catch (ex) {
+                logger.warn(`Failed to deserialize message protocol = ${protocol}`, ex);
                 if (protocol) {
-                    return deserialize(data, '');
-                } else {
                     return deserialize(data, supportedKernelWebSocketProtocols.v1KernelWebsocketJupyterOrg);
+                } else {
+                    return deserialize(data, '');
                 }
             }
         },
         serialize: (msg: KernelMessage.IMessage, protocol?: string) => {
             try {
                 return serialize(msg, protocol);
             } catch (ex) {
+                logger.warn(`Failed to serialize message protocol = ${protocol}`, ex);
                 if (protocol) {
-                    return serialize(msg, '');
-                } else {
                     return serialize(msg, supportedKernelWebSocketProtocols.v1KernelWebsocketJupyterOrg);
+                } else {
+                    return serialize(msg, '');
                 }
             }
         }