From 091fc027e77eeb84225176d2ddddc9b0bbc3c11a Mon Sep 17 00:00:00 2001 From: Don Jayamanne Date: Thu, 18 Jan 2024 12:28:18 +1100 Subject: [PATCH] Remove unwanted test (original issue has been resolved in upstream IPyKernel) (#15027) * Restore tests * Fixes --- .../notebook/executionService.vscode.test.ts | 46 ------------------- 1 file changed, 46 deletions(-) diff --git a/src/test/datascience/notebook/executionService.vscode.test.ts b/src/test/datascience/notebook/executionService.vscode.test.ts index e679b2a2b26..32f22882bf7 100644 --- a/src/test/datascience/notebook/executionService.vscode.test.ts +++ b/src/test/datascience/notebook/executionService.vscode.test.ts @@ -575,52 +575,6 @@ suite('Kernel Execution @kernelCore', function () { ) ]); }); - test.skip('Messages from background threads can come in other cell output', async function () { - // Details can be found in notebookUpdater.ts & https://github.com/jupyter/jupyter_client/issues/297 - // If you have a background thread in cell 1 & then immediately after that you have a cell 2. - // The background messages (output) from cell one will end up in cell 2. - const cell1 = await notebook.appendCodeCell( - dedent` - import time - import threading - from IPython.display import display - - def work(): - for i in range(10): - print('iteration %d'%i) - time.sleep(0.1) - - def spawn(): - thread = threading.Thread(target=work) - thread.start() - time.sleep(0.3) - - spawn() - print('main thread started') - ` - ); - const cell2 = await notebook.appendCodeCell('print("HELLO")'); - - await Promise.all([ - Promise.all(notebook.cells.map((cell) => kernelExecution.executeCell(cell))), - waitForCondition( - () => getTextOutputValues(cell1).includes('main thread started'), - defaultNotebookTestTimeout, - () => `'main thread started' not in output => '${getTextOutputValues(cell1)}'` - ), - waitForCondition( - async () => { - const secondCellOutput = getTextOutputValues(cell2); - expect(secondCellOutput).to.include('HELLO'); - // The last output from the first cell should end up in the second cell. - expect(secondCellOutput).to.include('iteration 9'); - return true; - }, - defaultNotebookTestTimeout, - () => `'iteration 9' and 'HELLO' not in second cell Output => '${getTextOutputValues(cell2)}'` - ) - ]); - }); test('Stderr & stdout outputs should go into separate outputs', async function () { const cell = await notebook.appendCodeCell( dedent`