Skip to content

Commit bea5bd6

Browse files
committed
test WIP
1 parent 7dbd1c1 commit bea5bd6

File tree

3 files changed

+17
-3
lines changed

3 files changed

+17
-3
lines changed

src/kernels/kernelProvider.web.ts

+2
Original file line numberDiff line numberDiff line change
@@ -80,6 +80,7 @@ export class KernelProvider extends BaseCoreKernelProvider {
8080
this.workspaceStorage
8181
) as IKernel;
8282
kernel.onRestarted(() => this._onDidRestartKernel.fire(kernel), this, this.disposables);
83+
kernel.onPostInitialized(() => this._onDidPostInitializeKernel.fire(kernel), this, this.disposables);
8384
kernel.onDisposed(() => this._onDidDisposeKernel.fire(kernel), this, this.disposables);
8485
kernel.onStarted(() => this._onDidStartKernel.fire(kernel), this, this.disposables);
8586
kernel.onStatusChanged(
@@ -132,6 +133,7 @@ export class ThirdPartyKernelProvider extends BaseThirdPartyKernelProvider {
132133
this.workspaceStorage
133134
);
134135
kernel.onRestarted(() => this._onDidRestartKernel.fire(kernel), this, this.disposables);
136+
kernel.onPostInitialized(() => this._onDidPostInitializeKernel.fire(kernel), this, this.disposables);
135137
kernel.onDisposed(() => this._onDidDisposeKernel.fire(kernel), this, this.disposables);
136138
kernel.onStarted(() => this._onDidStartKernel.fire(kernel), this, this.disposables);
137139
kernel.onStatusChanged(

src/kernels/kernelProvider.web.unit.test.ts

+1-1
Original file line numberDiff line numberDiff line change
@@ -17,7 +17,7 @@ import { ThirdPartyKernelProvider } from './kernelProvider.node';
1717
import { dispose } from '../platform/common/utils/lifecycle';
1818
import { noop } from '../test/core';
1919

20-
suite('Jupyter Session', () => {
20+
suite.only('Jupyter Session', () => {
2121
suite('Web Kernel Provider', function () {
2222
let disposables: IDisposable[] = [];
2323
const asyncDisposables: { dispose: () => Promise<unknown> }[] = [];

src/standalone/api/kernels/api.vscode.common.test.ts

+14-2
Original file line numberDiff line numberDiff line change
@@ -41,6 +41,7 @@ import { JVSC_EXTENSION_ID } from '../../../platform/common/constants';
4141
import { escapeStringToEmbedInPythonCode } from '../../../kernels/chat/generator';
4242
import { notebookCellExecutions } from '../../../platform/notebooks/cellExecutionStateService';
4343
import { createKernelApiForExtension } from './kernel';
44+
import { noop } from '../../../test/core';
4445

4546
suiteMandatory('Kernel API Tests @typescript', function () {
4647
const disposables: IDisposable[] = [];
@@ -203,7 +204,14 @@ suiteMandatory('Kernel API Tests @typescript', function () {
203204
})
204205
);
205206

206-
await realKernel.start();
207+
await realKernel.start({
208+
disableUI: true,
209+
onDidChangeDisableUI: () => ({
210+
dispose: noop
211+
})
212+
});
213+
assert.equal(startEventCounter, 0);
214+
207215
const kernel = createKernelApiForExtension(JVSC_EXTENSION_ID_FOR_TESTS, realKernel);
208216

209217
logger.info(`Execute code silently`);
@@ -226,12 +234,16 @@ suiteMandatory('Kernel API Tests @typescript', function () {
226234
disposables.push(
227235
kernels.onDidStart(({ kernel }) => {
228236
startEventCounter++;
229-
kernel.executeCode(`foo = ${startEventCounter}`, source.token);
237+
const codeToRun =
238+
startEventCounter === 0 ? `let foo = ${startEventCounter}` : `foo = ${startEventCounter}`;
239+
kernel.executeCode(codeToRun, source.token);
230240
})
231241
);
232242
await insertCodeCell('console.log(foo)', { index: 0, language: 'typescript' });
233243

234244
await realKernel.start();
245+
assert.equal(startEventCounter, 1);
246+
235247
const cell = notebook.cellAt(0)!;
236248
const executionOrderSet = createDeferred();
237249
const eventHandler = notebookCellExecutions.onDidChangeNotebookCellExecutionState((e) => {

0 commit comments

Comments
 (0)