From f80bf701a710328b20c5931d621e8d83813055ea Mon Sep 17 00:00:00 2001
From: Don Jayamanne <don.jayamanne@outlook.com>
Date: Wed, 11 Dec 2024 19:19:41 +1100
Subject: [PATCH] Deduplicate kernel completions including `*` prefix from
 pylance (#16286)

---
 .../intellisense/kernelCompletionProvider.ts  | 22 ++++++++++++++-----
 1 file changed, 16 insertions(+), 6 deletions(-)

diff --git a/src/standalone/intellisense/kernelCompletionProvider.ts b/src/standalone/intellisense/kernelCompletionProvider.ts
index 31967e0cb38..74de39e8075 100644
--- a/src/standalone/intellisense/kernelCompletionProvider.ts
+++ b/src/standalone/intellisense/kernelCompletionProvider.ts
@@ -135,14 +135,24 @@ class NotebookCellSpecificKernelCompletionProvider implements CompletionItemProv
 
             const existingCompletionItems = new Set(
                 (otherCompletions || [])
-                    .map((item) => (typeof item.label === 'string' ? item.label : item.label.label))
-                    // Jupyter kernel might return items prefixed with the `.` character.
-                    .map((item) => [item, `.${item}`])
+                    .map((item) => {
+                        const label = typeof item.label === 'string' ? item.label : item.label.label;
+                        const insertText = item.insertText;
+                        // Jupyter kernel might return items prefixed with the `.` character.
+                        const items = [label, `.${label}`];
+                        if (typeof insertText === 'string') {
+                            // Sometimes the labels returned by pylance can contain text like `* abspath`.
+                            // I.e. containing a prefix `*` followed by a space and then the text.
+                            items.push(insertText);
+                        }
+                        return items;
+                    })
                     .flat()
             );
-            return completions.filter(
-                (item) => !existingCompletionItems.has(typeof item.label === 'string' ? item.label : item.label.label)
-            );
+            return completions.filter((item) => {
+                const label = typeof item.label === 'string' ? item.label : item.label.label;
+                return !existingCompletionItems.has(label) && !existingCompletionItems.has(`* ${label}`);
+            });
         } catch (ex) {
             if (ex instanceof RequestTimedoutError) {
                 return [];