Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix open data viewer from debug variables window #15062

Merged
merged 5 commits into from
Jan 24, 2024

Conversation

amunger
Copy link
Contributor

@amunger amunger commented Jan 22, 2024

Fixes #15058
Fixes #15060

  • Pull request represents a single change (i.e. not fixing disparate/unrelated things in a single PR).
  • Title summarizes what is changing.
  • Appropriate comments and documentation strings in the code.
  • Has sufficient logging.
  • Has telemetry for feature-requests.
  • Unit tests & system/integration tests are added/updated.
  • Test plan is updated as appropriate.
  • package-lock.json has been regenerated by running npm install (if dependencies have changed).

@amunger
Copy link
Contributor Author

amunger commented Jan 22, 2024

@rebornix not sure if you want to go this way or just revert that other change so that we use the same type as the debug variables view context key

@amunger amunger requested a review from rebornix January 22, 2024 23:16
@amunger amunger marked this pull request as ready for review January 22, 2024 23:17
@vscodenpa vscodenpa added this to the December / January 2024 milestone Jan 22, 2024
@amunger amunger changed the title Aamunger/data viewer from debug fix open data viewer from debug variables window Jan 22, 2024
rebornix
rebornix previously approved these changes Jan 22, 2024
@aiday-mar
Copy link

aiday-mar commented Jan 24, 2024

Hey @amunger I am moving this PR to the February milestone since today is last development day before branching off, and there is a build error. Feel free to modify the milestone back if you believe this is a critical fix.

@aiday-mar aiday-mar modified the milestones: December / January 2024, February 2024 Jan 24, 2024
@amunger
Copy link
Contributor Author

amunger commented Jan 24, 2024

This is a regression that I believe we need to fix

@amunger amunger modified the milestones: February 2024, December / January 2024 Jan 24, 2024
@amunger amunger enabled auto-merge (squash) January 24, 2024 18:01
@amunger amunger merged commit f80095b into main Jan 24, 2024
28 checks passed
@amunger amunger deleted the aamunger/dataViewerFromDebug branch January 24, 2024 18:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Test Failure 'Open dataviewer:' can't open data viewer from Python debug variables view
4 participants