-
Notifications
You must be signed in to change notification settings - Fork 497
Improving the azure browse filter dropdown logic #18281
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
PR Changes
|
@@ -1138,14 +1138,16 @@ export class ConnectionDialogWebviewController extends ReactWebviewPanelControll | |||
string[] | undefined | |||
>(azureSubscriptionFilterConfigKey) !== undefined; | |||
|
|||
const startTime = Date.now(); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Maybe we should create a helper function to track time. It would return another function that, when called, automatically measures the elapsed time and sends the action event with the mentioned properties.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I like this thought. I'll make an issue to add some util stuff like that.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks like a solid improvement to me!
Refining and consolidating the logic to have more intuitive default logic. The overall logic is now:
server
always selects the first one in the list to make sure it's always populated, unless the user has explicitly cleared itAlso adding several telemetry more points around Azure load times and errors
Note: because contents of subscriptions are loaded asynchronously, different servers may end up being selected each time depending on which subscriptions finish first. I thought it would be more confusing to swap the selection around to (e.g.) the first alphabetically as new entries loaded, so /shrug. The other dropdowns don't have that issue because they aren't set to always make a selection when available.