Skip to content

Minor styling updates #19468

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
May 23, 2025
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 1 addition & 4 deletions src/reactviews/common/forms/form.component.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -176,10 +176,7 @@ export const FormField = <
return (
<Button
key={idx + actionButton.id}
appearance="outline"
style={{
width: "120px",
}}
style={{ width: "auto", whiteSpace: "nowrap" }}
onClick={() =>
context?.formAction({
propertyName: component.propertyName,
Expand Down
14 changes: 14 additions & 0 deletions src/reactviews/common/styles.ts
Original file line number Diff line number Diff line change
@@ -0,0 +1,14 @@
/*---------------------------------------------------------------------------------------------
* Copyright (c) Microsoft Corporation. All rights reserved.
* Licensed under the MIT License. See License.txt in the project root for license information.
*--------------------------------------------------------------------------------------------*/

import { makeStyles } from "@fluentui/react-components";

export const useAccordionStyles = makeStyles({
accordionItem: {
border: "0.5px solid var(--vscode-editorWidget-border)",
borderRadius: "2px",
margin: "10px",
},
});
Original file line number Diff line number Diff line change
Expand Up @@ -28,6 +28,7 @@ import {
ConnectionDialogWebviewState,
IConnectionDialogProfile,
} from "../../../../sharedInterfaces/connectionDialog";
import { useAccordionStyles } from "../../../common/styles";

export const AdvancedOptionsDrawer = ({
isAdvancedDrawerOpen,
Expand All @@ -39,6 +40,7 @@ export const AdvancedOptionsDrawer = ({
const context = useContext(ConnectionDialogContext);
const [searchSettingsText, setSearchSettingText] = useState<string>("");
const [userOpenedSections, setUserOpenedSections] = useState<string[]>(["General"]);
const accordionStyles = useAccordionStyles();

if (context === undefined) {
return undefined;
Expand Down Expand Up @@ -119,7 +121,10 @@ export const AdvancedOptionsDrawer = ({
.filter((group) => doesGroupHaveVisibleOptions(group))
.map((group, groupIndex) => {
return (
<AccordionItem value={group.groupName} key={groupIndex}>
<AccordionItem
value={group.groupName}
key={groupIndex}
className={accordionStyles.accordionItem}>
<AccordionHeader>{group.groupName}</AccordionHeader>
<AccordionPanel>
{group.options
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -425,6 +425,7 @@ export const ObjectExplorerFilterPage = () => {
<Tooltip content="Clear" relationship="label">
<Button
size="small"
appearance="subtle"
icon={<EraserRegular />}
onClick={() => {
if (
Expand Down
11 changes: 3 additions & 8 deletions src/reactviews/pages/TableDesigner/designerPropertiesPane.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -28,6 +28,7 @@ import {
} from "../../../sharedInterfaces/tableDesigner";
import { ChevronRightFilled, ChevronLeftFilled, DismissRegular } from "@fluentui/react-icons";
import { locConstants } from "../../common/locConstants";
import { useAccordionStyles } from "../../common/styles";

const useStyles = makeStyles({
root: {
Expand Down Expand Up @@ -68,6 +69,7 @@ const useStyles = makeStyles({

export const DesignerPropertiesPane = () => {
const classes = useStyles();
const accordionStyles = useAccordionStyles();
const context = useContext(TableDesignerContext);
if (!context) {
return null;
Expand Down Expand Up @@ -100,14 +102,7 @@ export const DesignerPropertiesPane = () => {
return undefined;
}
return (
<AccordionItem
value={group}
key={group}
style={{
border: "0.5px solid var(--vscode-editorWidget-border)",
borderRadius: "2px",
margin: "10px",
}}>
<AccordionItem value={group} className={accordionStyles.accordionItem} key={group}>
<AccordionHeader>{group}</AccordionHeader>
<AccordionPanel>
<div className={classes.group}>
Expand Down
Loading