Skip to content

Porting "Improving logging for Azure account sign-in for connection" #19465 and #19497 #19493

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
May 29, 2025
Merged

Porting "Improving logging for Azure account sign-in for connection" #19465 and #19497 #19493

merged 2 commits into from
May 29, 2025

Conversation

Benjin
Copy link
Contributor

@Benjin Benjin commented May 28, 2025 •
edited
Loading

Users are encountering issues when signing in with Entra auth, additional logging is needed to see why newly-authenticated users are not seeing their accounts show up in the connection dialog dropdown.

Original PR: #19465 and #19497
Bug: #19491

@Benjin
Improving logging for Azure account sign-in for connection (#19465)
65e9677 
* improving logging for Azure account sign-in

* Error handling around stale credentials

* another case

* revert styling

* adding tests
@Benjin Benjin requested a review from kburtram as a code owner May 28, 2025 16:56
@Benjin Benjin closed this May 28, 2025
@github-actions GitHub Actions
Copy link

github-actions bot commented May 28, 2025 •
edited
Loading

PR Changes

Category Main Branch PR Branch Difference
Code Coverage 58.54% 55.10% $${\color{lightgreen} -3.44\% }$$
VSIX Size 15304 KB 15296 KB $${\color{lightgreen} -8 KB \space (0\%) }$$
Webview Bundle Size 3688 KB 3656 KB $${\color{lightgreen} -32 KB \space (0\%) }$$

@Benjin Benjin reopened this May 28, 2025
@Benjin Benjin changed the title Porting "Improving logging for Azure account sign-in for connection #19465" Porting "Improving logging for Azure account sign-in for connection #19465 and #19497" May 28, 2025
@Benjin Benjin changed the title Porting "Improving logging for Azure account sign-in for connection #19465 and #19497" Porting "Improving logging for Azure account sign-in for connection" #19465 and #19497 May 28, 2025
@kburtram kburtram merged commit c8ef790 into release/1.32 May 29, 2025
6 checks passed
@kburtram kburtram deleted the port/benjin/19465 branch May 29, 2025 21:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kburtram kburtram kburtram approved these changes

@aasimkhan30 aasimkhan30 Awaiting requested review from aasimkhan30 aasimkhan30 is a code owner

@caohai caohai Awaiting requested review from caohai caohai is a code owner

@laurenastrid1 laurenastrid1 Awaiting requested review from laurenastrid1 laurenastrid1 is a code owner

@lewis-sanchez lewis-sanchez Awaiting requested review from lewis-sanchez lewis-sanchez is a code owner

Assignees
No one assigned
Labels
Port Request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Benjin @kburtram