Skip to content

Fix big schema rendering behavior in schema designer. #19494

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 6 commits into from
May 29, 2025

Conversation

aasimkhan30
Copy link
Contributor

Pull Request Template – vscode-mssql

Description

  1. This PR enables an option in react flow component for schema designer to only render visible nodes. Helps in render times and overall responsiveness for the component.

Due to this change, I had to change the find node functionality from being event based to a having the query text stored in context.

As it was event based, unrendered nodes never received the event. Now I don't have to worry about it since the actual value is fetched from the context.

  1. Fixes the export button to get bounds of only visible nodes.
  2. Fixes Filter button to hide edges of hidden nodes.

Code Changes Checklist

  • New or updated unit tests added
  • All existing tests pass (npm run test)
  • Code follows contributing guidelines
  • Telemetry/logging updated if relevant
  • No regressions or UX breakage

Reviewers: Please read our reviewer guidelines

Copy link

github-actions bot commented May 28, 2025

PR Changes

Category Main Branch PR Branch Difference
Code Coverage 58.55% 58.24% $${\color{lightgreen} -.31\% }$$
VSIX Size 15304 KB 15319 KB $${\color{lightgreen} 15 KB \space (0\%) }$$
Webview Bundle Size 3688 KB 3692 KB $${\color{lightgreen} 4 KB \space (0\%) }$$

@aasimkhan30 aasimkhan30 merged commit 3ed2d68 into main May 29, 2025
5 checks passed
@aasimkhan30 aasimkhan30 deleted the aasim/fix/bigSchemas branch May 29, 2025 17:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants