Skip to content

Adding some additional entra logging #19497

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
May 28, 2025
Merged

Adding some additional entra logging #19497

merged 1 commit into from
May 28, 2025

Conversation

Benjin
Copy link
Contributor

@Benjin Benjin commented May 28, 2025

Pull Request Template – vscode-mssql

Description

Logging wasn't displaying the logged-in user account properly. I also took this opportunity to be even more verbose for the accounts being read from the cache.

Code Changes Checklist

  • New or updated unit tests added
  • All existing tests pass (npm run test)
  • Code follows contributing guidelines
  • Telemetry/logging updated if relevant
  • No regressions or UX breakage

Reviewers: Please read our reviewer guidelines

@github-actions GitHub Actions
Copy link

PR Changes

Category Main Branch PR Branch Difference
Code Coverage 58.55% 58.46% $${\color{lightgreen} -.09\% }$$
VSIX Size 15304 KB 15319 KB $${\color{lightgreen} 15 KB \space (0\%) }$$
Webview Bundle Size 3688 KB 3688 KB $${\color{lightgreen} 0 KB \space (0\%) }$$

@Benjin Benjin merged commit a762149 into main May 28, 2025
5 checks passed
@Benjin Benjin deleted the dev/benjin/moreEntraLogging branch May 28, 2025 18:15
Benjin added a commit that referenced this pull request May 28, 2025
@Benjin
Additional entra logging (#19497)
47441d9
@Benjin Benjin mentioned this pull request May 28, 2025
Merged
kburtram pushed a commit that referenced this pull request May 29, 2025
@Benjin
Porting "Improving logging for Azure account sign-in for connection" #…
c8ef790 
…19465 and #19497 (#19493)

* Improving logging for Azure account sign-in for connection (#19465)

* improving logging for Azure account sign-in

* Error handling around stale credentials

* another case

* revert styling

* adding tests

* Additional entra logging (#19497)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aasimkhan30 aasimkhan30 aasimkhan30 approved these changes

@kburtram kburtram Awaiting requested review from kburtram kburtram is a code owner

@caohai caohai Awaiting requested review from caohai caohai is a code owner

@laurenastrid1 laurenastrid1 Awaiting requested review from laurenastrid1 laurenastrid1 is a code owner

@lewis-sanchez lewis-sanchez Awaiting requested review from lewis-sanchez lewis-sanchez is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Benjin @aasimkhan30