Skip to content

Adding dynamic updating to code lens active connection. #19504

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
May 29, 2025

Conversation

aasimkhan30
Copy link
Contributor

Pull Request Template – vscode-mssql

Description

This update adds dynamic updating for the active CodeLens connection when connection changes are made outside the editor.
It also refactors the connection manager to use the VS Code EventEmitter instead of the Node.js Event

Code Changes Checklist

  • New or updated unit tests added
  • All existing tests pass (npm run test)
  • Code follows contributing guidelines
  • Telemetry/logging updated if relevant
  • No regressions or UX breakage

Reviewers: Please read our reviewer guidelines

Copy link

PR Changes

Category Main Branch PR Branch Difference
Code Coverage 58.52% 58.45% $${\color{lightgreen} -.07\% }$$
VSIX Size 15304 KB 15319 KB $${\color{lightgreen} 15 KB \space (0\%) }$$
Webview Bundle Size 3688 KB 3688 KB $${\color{lightgreen} 0 KB \space (0\%) }$$

@aasimkhan30
Copy link
Contributor Author

@lewis-sanchez , can you please verify if schema compare feature is working fine?


constructor(private _connectionManager: ConnectionManager) {
this._disposables.push(
this._connectionManager.onConnectionsChanged(() => {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What connection changes from outside the editor are occuring that we want to impact the editor? For example, if I open an editor from a specific connection, then edit the connection (using the connection dialog), I don't think we'd want to change that editor's already-established connection. Are there other instances this is capturing?

Copy link
Contributor Author

@aasimkhan30 aasimkhan30 May 29, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

By "outside the editor," I mean if you change the connection using the status bar at the bottom, or if Copilot opens an untitled editor and connects it to a different database.

@aasimkhan30 aasimkhan30 merged commit d6327db into main May 29, 2025
5 checks passed
@aasimkhan30 aasimkhan30 deleted the aasim/fix/codeLensDynamicUpdate branch May 29, 2025 22:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants