Skip to content

fix: terminal error notification in untrusted workspace #24993

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 18, 2025
Merged

fix: terminal error notification in untrusted workspace #24993

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 7 additions & 4 deletions src/client/terminals/envCollectionActivation/shellIntegrationService.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,6 +15,7 @@ import { IDisposableRegistry, IPersistentStateFactory } from '../../common/types
import { sleep } from '../../common/utils/async';
import { traceError, traceVerbose } from '../../logging';
import { IShellIntegrationDetectionService } from '../types';
import { isTrusted } from '../../common/vscodeApis/workspaceApis';

/**
* This is a list of shells which support shell integration:
Expand Down Expand Up @@ -151,10 +152,12 @@ export class ShellIntegrationDetectionService implements IShellIntegrationDetect
* Creates a dummy terminal so that we are guaranteed a data write event for this shell type.
*/
private createDummyHiddenTerminal(shell: string) {
this.terminalManager.createTerminal({
shellPath: shell,
hideFromUser: true,
});
if (isTrusted()) {
this.terminalManager.createTerminal({
shellPath: shell,
hideFromUser: true,
});
}
}
}

Expand Down
Loading