More specific llm tools #25072
Merged
More specific llm tools #25072
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DonJayamanne
added
no-changelog
DonJayamanne
commented
May 15, 2025
| }, | ||
| "when": "!pythonEnvExtensionInstalled" |
There was a problem hiding this comment.
Will disable listPythonPackages for now
DonJayamanne
commented
May 15, 2025
| @@ -17,6 +17,7 @@ suite('Python Path Settings Updater', () => { | |||
| serviceContainer = TypeMoq.Mock.ofType<IServiceContainer>(); | |||
| workspaceService = TypeMoq.Mock.ofType<IWorkspaceService>(); | |||
| interpreterPathService = TypeMoq.Mock.ofType<IInterpreterPathService>(); | |||
| experimentsManager = TypeMoq.Mock.ofType<IExperimentService>(); | |||
There was a problem hiding this comment.
Fix some errors in other parts of the code that ws causing issues
DonJayamanne
commented
May 15, 2025
| @@ -36,6 +37,11 @@ suite('Execution Flow Run Adapters', () => { | |||
| let useEnvExtensionStub: sinon.SinonStub; | |||
|
|
|||
| setup(() => { | |||
| const proc = typeMoq.Mock.ofType<MockChildProcess>(); | |||
There was a problem hiding this comment.
Fix some errors in other parts of the code that ws causing issues
DonJayamanne
commented
May 15, 2025
| @@ -62,7 +62,7 @@ export async function updateSetting( | |||
| configTarget: ConfigurationTarget, | |||
| ) { | |||
| const vscode = require('vscode') as typeof import('vscode'); | |||
| const settings = vscode.workspace.getConfiguration('python', { uri: resource, languageId: 'python' } || null); | |||
| const settings = vscode.workspace.getConfiguration('python', { uri: resource, languageId: 'python' }); | |||
There was a problem hiding this comment.
|| null was not required, as its impossible for object to be empty.
was getting these errors locally.
karthiknadig
approved these changes
May 15, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.