Configure Python Env tool #25091
Merged
Configure Python Env tool #25091
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DonJayamanne
commented
May 20, 2025
| } | ||
| }, | ||
| { | ||
| "name": "list_python_packages", |
There was a problem hiding this comment.
Removed this tool, was disabled
DonJayamanne
added
no-changelog
DonJayamanne
commented
May 20, 2025
| @@ -103,10 +103,11 @@ export function registerCreateEnvironmentFeatures( | |||
| registerCreateEnvironmentProvider(condaCreationProvider()), | |||
| onCreateEnvironmentExited(async (e: EnvironmentDidCreateEvent) => { | |||
| if (e.path && e.options?.selectEnvironment) { | |||
| await interpreterPathService.update( | |||
There was a problem hiding this comment.
@karthiknadig Found that this is another place where user action results in updating the Python path.
Instead of injecting another dependency, I decided to use the more generic one that is responsible for all updates to python path,
DonJayamanne
commented
May 20, 2025
|
|
||
| async activate(_resource: Resource, _startupStopWatch?: StopWatch): Promise<void> { | ||
| this.extensionContext.subscriptions.push( | ||
| commands.registerCommand('python.getRecommendedEnvironment', async (resource: Resource) => { |
There was a problem hiding this comment.
Creating a command, I think command is simpler as Jupyter and Python Env extension will need this API.
DonJayamanne
commented
May 20, 2025
| @@ -569,7 +569,10 @@ export class SetInterpreterCommand extends BaseInterpreterSelectorCommand implem | |||
| * @returns true when an interpreter was set, undefined if the user cancelled the quickpick. | |||
| */ | |||
| @captureTelemetry(EventName.SELECT_INTERPRETER) | |||
| public async setInterpreter(): Promise<true | undefined> { | |||
| public async setInterpreter(options?: { | |||
There was a problem hiding this comment.
@karthiknadig I added back button and actions into the interpreter quick pick
DonJayamanne
commented
May 20, 2025
| resourcePath?: string; | ||
| } | ||
|
|
||
| export class ListPythonPackagesTool implements LanguageModelTool<IResourceReference> { |
rebornix
approved these changes
May 20, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.