Skip to content

Prefer using Notebook tools over Python tools for notebooks #25098

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
May 21, 2025

Conversation

DonJayamanne
Copy link

@DonJayamanne DonJayamanne commented May 21, 2025

@karthiknadig @eleanorjboyd @rebornix @amunger
This change will change how the Python tools work.
The python tools will no longer work with Notebooks.
Previously it would,

From my testing, this change works perfectly well.

I think thats fraught with danger. There are a lot of things to consider.
Ideally there should ever be only one way of doing things, whether its local/remote/python/non-python notebooks.

);
}
throw new Error(
`This tool cannot be used for Jupyter Notebooks. Install the Jupyter Extension (${JUPYTER_EXTENSION_ID}) & try using notebook specific tools instead.`,
Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@rebornix From my testing this works as expected.

@DonJayamanne DonJayamanne marked this pull request as ready for review May 21, 2025 01:49
@vs-code-engineering vs-code-engineering bot added this to the May 2025 milestone May 21, 2025
@DonJayamanne DonJayamanne marked this pull request as draft May 21, 2025 01:51
@DonJayamanne DonJayamanne added no-changelog No news entry required skip package*.json package.json and package-lock.json don't both need updating skip tests Updates to tests unnecessary skip-issue-check labels May 21, 2025
@DonJayamanne DonJayamanne marked this pull request as ready for review May 21, 2025 01:55
@DonJayamanne DonJayamanne merged commit 8ae346b into main May 21, 2025
85 checks passed
@DonJayamanne DonJayamanne deleted the don/instant-barnacle branch May 21, 2025 03:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
no-changelog No news entry required skip package*.json package.json and package-lock.json don't both need updating skip tests Updates to tests unnecessary skip-issue-check
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants