Skip to content

Switch node-keytar into optional dependency #786

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
felipecrs opened this issue Nov 17, 2022 · 2 comments · Fixed by #795
Closed

Switch node-keytar into optional dependency #786

felipecrs opened this issue Nov 17, 2022 · 2 comments · Fixed by #795
Assignees
@joaomoreno
Labels
engineering

Comments

@felipecrs
Copy link
Contributor

felipecrs commented Nov 17, 2022 •
edited
Loading

As far as I know, node-keytar is only used for authentication when NOT using the VSCE_PAT, therefore it is an optional dependency, which is a potential fix for:

References

https://docs.npmjs.com/cli/v9/configuring-npm/package-json#optionaldependencies
@felipecrs felipecrs mentioned this issue Nov 17, 2022
Merged
5 tasks
felipecrs added a commit to vscode-shellcheck/vscode-shellcheck that referenced this issue Nov 17, 2022
@felipecrs
build(deps): use x86 binary on windows for arm
cc00466 
With workaround until microsoft/vscode-vsce#786
is not fixed.

Closes #824
@felipecrs felipecrs mentioned this issue Nov 17, 2022
Merged
felipecrs added a commit to vscode-shellcheck/vscode-shellcheck that referenced this issue Nov 17, 2022
@felipecrs
build(deps): use x86 binary on windows for arm (#825)
de6d2e4 
With workaround until microsoft/vscode-vsce#786
is not fixed.

Closes #824
@joaomoreno joaomoreno self-assigned this Nov 17, 2022
@joaomoreno joaomoreno added the feature-request Request for new features or functionality label Nov 17, 2022
@felipecrs
Copy link
Contributor Author

felipecrs commented Dec 5, 2022 •
edited
Loading

@joaomoreno I took a look at the source code, and it seems that keytar is already treated as being optional (i.e, code will automatically fallback to the file store if keytar doesn't open). All that is left is to:

"dependencies": {
	"azure-devops-node-api": "^11.0.1",
	"chalk": "^2.4.2",
	"cheerio": "^1.0.0-rc.9",
	"commander": "^6.1.0",
	"glob": "^7.0.6",
	"hosted-git-info": "^4.0.2",
-       "keytar": "^7.7.0"
	"leven": "^3.1.0",
	"markdown-it": "^12.3.2",
	"mime": "^1.3.4",
	"minimatch": "^3.0.3",
	"parse-semver": "^1.1.1",
	"read": "^1.0.7",
	"semver": "^5.1.0",
	"tmp": "^0.2.1",
	"typed-rest-client": "^1.8.4",
	"url-join": "^4.0.1",
	"xml2js": "^0.4.23",
	"yauzl": "^2.3.1",
	"yazl": "^2.2.2"
},
+ "optionalDependencies": {
+ 	"keytar": "^7.7.0"
+ },

@felipecrs felipecrs mentioned this issue Dec 5, 2022
Merged
@joaomoreno joaomoreno added engineering and removed feature-request Request for new features or functionality labels Dec 7, 2022
@joaomoreno joaomoreno added this to the December 2022 milestone Dec 7, 2022
@joaomoreno joaomoreno mentioned this issue Dec 7, 2022
Merged
joaomoreno added a commit that referenced this issue Dec 7, 2022
@joaomoreno
keytar should be optional
c044f6c 
fixes #786
joaomoreno added a commit that referenced this issue Dec 7, 2022
@joaomoreno
keytar should be optional (#795)
1936e8b 
fixes #786
@felipecrs
Copy link
Contributor Author

Thanks a lot!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@joaomoreno joaomoreno

Labels
engineering
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

keytar should be optional microsoft/vscode-vsce
2 participants
@joaomoreno @felipecrs