Fixes #143635 by marking audioCues.enabled as deprecated, but also using that value if it is still set.

Author: hediet

src/vs/workbench/contrib/audioCues/browser/audioCueService.ts

@@ -62,6 +62,13 @@ export class AudioCueService extends Disposable implements IAudioCueService {
 		}
 	}
 
+	private readonly obsoleteAudioCuesEnabled = observableFromEvent(
+		Event.filter(this.configurationService.onDidChangeConfiguration, (e) =>
+			e.affectsConfiguration('audioCues.enabled')
+		),
+		() => this.configurationService.getValue<'on' | 'off' | 'auto'>('audioCues.enabled')
+	);
+
 	private readonly isEnabledCache = new Cache((cue: AudioCue) => {
 		const settingObservable = observableFromEvent(
 			Event.filter(this.configurationService.onDidChangeConfiguration, (e) =>
@@ -71,11 +78,21 @@ export class AudioCueService extends Disposable implements IAudioCueService {
 		);
 		return new LazyDerived(reader => {
 			const setting = settingObservable.read(reader);
-			if (setting === 'auto') {
-				return this.screenReaderAttached.read(reader);
-			} else if (setting === 'on') {
+			if (
+				setting === 'on' ||
+				(setting === 'auto' && this.screenReaderAttached.read(reader))
+			) {
+				return true;
+			}
+
+			const obsoleteSetting = this.obsoleteAudioCuesEnabled.read(reader);
+			if (
+				obsoleteSetting === 'on' ||
+				(obsoleteSetting === 'auto' && this.screenReaderAttached.read(reader))
+			) {
 				return true;
 			}
+
 			return false;
 		}, 'audio cue enabled');
 	});

src/vs/workbench/contrib/audioCues/browser/audioCues.contribution.ts

@@ -31,11 +31,11 @@ const audioCueFeatureBase: IConfigurationPropertySchema = {
 	],
 };
 
-// TODO@hediet: Migrate audioCues.enabled setting!
-// audioCues.enabled -> audioCues.{lineHasBreakpoint, lineHasInlineCompletion, ...}
-
 Registry.as<IConfigurationRegistry>(ConfigurationExtensions.Configuration).registerConfiguration({
 	'properties': {
+		'audioCues.enabled': {
+			deprecationMessage: 'Deprecated. Use the specific setting for each audio cue instead (`audioCues.*`).',
+		},
 		'audioCues.lineHasBreakpoint': {
 			'description': localize('audioCues.lineHasBreakpoint', "Plays a sound when the active line has a breakpoint."),
 			...audioCueFeatureBase,