PHP syntax highlighting does not correctly detect end of string

[pedroterzero]

Does this issue occur when all extensions are disabled?: Yes

Version: 1.66.0
Commit: e18005f0f1b33c29e81d732535d8c0e47cafb0b5
Date: 2022-03-30T05:50:41.156Z
Electron: 17.2.0
Chromium: 98.0.4758.109
Node.js: 16.13.0
V8: 9.8.177.11-electron.0
OS: Linux x64 5.13.0-39-generic snap

OS is Ubuntu 20.04

Description

When I use a string variable formatted as in the example, code after the variable is incorrectly coloured

This is what it ends up looking like for me:

I'd expect this to parse the string correctly. The output should look more like this:

Test case:

<?php

$test = 'AND [' . $foo['bar'];

// hi i am a comment
if (true) {
    print 'test';
}

Steps to Reproduce:

Create a test file, test.php with the contents from the test case

[alexr00]

@pedroterzero it looks like the PHP grammar we use assumes that strings that start with AND are sql. Is it your intent that $test is sql?

[pedroterzero]

@pedroterzero it looks like the PHP grammar we use assumes that strings that start with AND are sql. Is it your intent that $test is sql?

In this particular instance it happened to be a SOLR query with a range query. It's a legacy project.

[alexr00]

Thanks! I've moved this issue to the upstream repo that we get our PHP syntax highlighting grammar from: atom/language-php#453