Support when clause for terminal.profiles contribution point

[isc-bsaviano]

I am in the process of implementing a virtual terminal using ExtensionTerminalOptions for my extension. The terminal can only be created if some conditions are met. I would like to hide the terminal profile from the menu if the conditions aren't true. Can you add support for a when clause in the terminal.profiles contribution point so this becomes possible? Thanks!

[vscodenpa]

This feature request is now a candidate for our backlog. The community has 60 days to upvote the issue. If it receives 20 upvotes we will move it to our backlog. If not, we will close it. To learn more about how we handle feature requests, please see our documentation.

Happy Coding!

[Tyriar]

My main concern here is that it's very easy for when clauses to change a lot during the lifecycle of the editor, it would be easy for extension authors to make mistakes that could look like bugs in VS Code. Having a default profile configured with a when clause would also show warnings in settings and lead to other weird behavior like falling back to the default.

Could you elaborate on your use case? It's not clear when this would be used exactly intersystems-community/vscode-objectscript#1150. Is this just a minor polish issue in your view/

[isc-bsaviano]

The virtual terminal that I am implementing requires a remote server connection. That connection is defined in the settings.json file, but it could be "inactive" for many reasons (bad network connection, bad credentials, intentionally turned off by the user, etc). We use a custom context key and when clauses to hide menu options that can't be used without that server connection. Since we can't do that for the terminal profile, users will still see ours in the menu and will get an error message popup when they do. IMO it's much cleaner to be able to hide that option entirely, but I agree that this is just minor polish.

[gjsjohnmurray]

I support this and have upvoted it. Previously requested in #144135 but closed with #144135 (comment)

Pinging @SeaDve