Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Inconsistent comments in comments view #203484

Closed
amunger opened this issue Jan 25, 2024 · 6 comments
Closed

Inconsistent comments in comments view #203484

amunger opened this issue Jan 25, 2024 · 6 comments
Assignees

Comments

@amunger
Copy link
Contributor

amunger commented Jan 25, 2024

While verifying #200972, I made some a few comments in microsoft/vscode-jupyter#15063 in the github page, insiders-vscode.dev and desktop vscode.
Both .dev and desktop are missing 1 of the 4 comments, but not the same one. Running Refresh Pull Request Comments doesn't fix it.

Inconsistent comment list
image

@alexr00
Copy link
Member

alexr00 commented Jan 26, 2024

@amunger were changes pushed to the PR while you were leaving these comments? I'm wondering if one of your instances was on an earlier commit and couldn't find the right location for the comment.

@amunger
Copy link
Contributor Author

amunger commented Jan 26, 2024

No commits were made while I was testing this out.
I tried again today, pulled in the latest main with similar results again at first, and but .dev pulled in a comment from a different PR, and after clicking around, it's only showing that unrelated comment.
image

@alexr00
Copy link
Member

alexr00 commented Jan 29, 2024

What branch do you have checked out in each of those instances? It looks like you're on two different branches since on desktop we aren't detecting that you have a PR checked out and on vscode.dev we are detecting that you have a PR checked out.

@amunger
Copy link
Contributor Author

amunger commented Jan 29, 2024

I'm pretty sure I was just on main in the desktop, though trying again today, I don't see any comments until I check out the PR. I was just viewing the changes from the github sidebar as shown there. So, no longer repro'ing on desktop if that's expected.

For .dev, I can still see just three comments when I start viewing the PR while on the main branch, and then after opening the file with the fourth comment, that one shows up too.

@amunger
Copy link
Contributor Author

amunger commented Jan 29, 2024

Feel free to close as won't fix and wait for more feedback - pretty small issue at this point

@alexr00
Copy link
Member

alexr00 commented Jan 30, 2024

For .dev, I can still see just three comments when I start viewing the PR while on the main branch, and then after opening the file with the fourth comment, that one shows up too.

This sounds like it's by design. The initial 3 comments are coming from the PR you have checked out. The additional 4th comment is coming from a different PR: the PR you have expanded in the "Pull Requests" tree and where you clicked on the file.

@alexr00 alexr00 closed this as completed Jan 30, 2024
@microsoft microsoft locked and limited conversation to collaborators Jun 10, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants