-
Notifications
You must be signed in to change notification settings - Fork 31k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Inconsistent comments in comments view #203484
Comments
@amunger were changes pushed to the PR while you were leaving these comments? I'm wondering if one of your instances was on an earlier commit and couldn't find the right location for the comment. |
What branch do you have checked out in each of those instances? It looks like you're on two different branches since on desktop we aren't detecting that you have a PR checked out and on vscode.dev we are detecting that you have a PR checked out. |
I'm pretty sure I was just on main in the desktop, though trying again today, I don't see any comments until I check out the PR. I was just viewing the changes from the github sidebar as shown there. So, no longer repro'ing on desktop if that's expected. For .dev, I can still see just three comments when I start viewing the PR while on the main branch, and then after opening the file with the fourth comment, that one shows up too. |
Feel free to close as won't fix and wait for more feedback - pretty small issue at this point |
This sounds like it's by design. The initial 3 comments are coming from the PR you have checked out. The additional 4th comment is coming from a different PR: the PR you have expanded in the "Pull Requests" tree and where you clicked on the file. |
While verifying #200972, I made some a few comments in microsoft/vscode-jupyter#15063 in the github page, insiders-vscode.dev and desktop vscode.
Both .dev and desktop are missing 1 of the 4 comments, but not the same one. Running
Refresh Pull Request Comments
doesn't fix it.Inconsistent comment list

The text was updated successfully, but these errors were encountered: