Skip to content

Remove CredentialsService & keytar #192224

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Sep 6, 2023
Merged

Remove CredentialsService & keytar #192224

merged 4 commits into from
Sep 6, 2023

Conversation

TylerLeonhardt
Copy link
Member

@TylerLeonhardt TylerLeonhardt commented Sep 5, 2023 •
edited
Loading

fixes #115215
fixes #143395

@TylerLeonhardt TylerLeonhardt enabled auto-merge (squash) September 5, 2023 18:22
@TylerLeonhardt TylerLeonhardt self-assigned this Sep 5, 2023
@vscodenpa vscodenpa added this to the September 2023 milestone Sep 5, 2023
@TylerLeonhardt TylerLeonhardt mentioned this pull request Sep 5, 2023
Closed
@TylerLeonhardt TylerLeonhardt merged commit 5134662 into main Sep 6, 2023
@TylerLeonhardt TylerLeonhardt deleted the tyler/familiar-albatross branch September 6, 2023 00:47
@joaomoreno
Copy link
Member

ding dong, the witch is dead

@deepak1556 deepak1556 mentioned this pull request Sep 6, 2023
Merged
@github-actions github-actions bot locked and limited conversation to collaborators Oct 21, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@joyceerhl joyceerhl joyceerhl approved these changes

Assignees

@TylerLeonhardt TylerLeonhardt

Labels
None yet
Projects
None yet
Milestone
September 2023
Development

Successfully merging this pull request may close these issues.

keytar brings in a lot of files in the build Remove keytar shim
4 participants
@TylerLeonhardt @joaomoreno @joyceerhl @vscodenpa