Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New module Microsoft.Windows.Settings #158

Open
wants to merge 11 commits into
base: main
Choose a base branch
from

Conversation

Gijsreyn
Copy link
Contributor

@Gijsreyn Gijsreyn commented Feb 16, 2025


This PR introduces the new Microsoft.Windows.Settings module. The module will become responsible for configuring a variety of Windows settings without the need for separate individual modules. This addresses the overall modularization, standardization, and introduces the DSC community guidelines.

Microsoft Reviewers: Open in CodeFlow

This comment has been minimized.

This comment has been minimized.

@Gijsreyn
Copy link
Contributor Author

Gijsreyn commented Feb 16, 2025

Hello @denelon and @AmelBawa-msft. As an attempt to address multiple challenges, e.g., script analyzer, modularization, and standardization, this is the main module Microsoft.Windows.Settings. I recognize this PR might be quite large, but yes, it's the output Sampler generates. I've explicitly left the azure-pipelines.yml file intact, so there's a reference to how it can be built up; as you mentioned earlier, the pipelines were being reviewed.

I intend to make the module the grandfather of all Windows Settings and slowly move the other modules that have either already been released or are open for pull requests to be added in here. That way, they follow a certain standard, and we don't constantly have to use the same functions repeatedly. Of course, not all registry settings have either 0 or 1. In that case, they will be more self-contained.

P.S. Perhaps the GuestConfiguration module that also uses Sampler already gots details how to build the Azure Pipelines.

@denelon
Copy link
Contributor

denelon commented Feb 18, 2025

Thanks! I've got some discussions planned today with @AmelBawa-msft to cover the roadmap for Microsoft.Windows.Setting - I think we may want to stick with the singular name, but I'm open to whichever is best for being idiomatically correct in terms of PowerShell.

@Gijsreyn
Copy link
Contributor Author

Awesome Demitrius. I took the plural name because as with the others that were developed already, it could contain one or more settings. In this case, it will definitely contain more settings. There isn't really a strongly encouraged development guideline for module names (only for cmdlets, it should be singular), and I also took some reference from the Az module (e.g., Az.Accounts, `Az.Resources).

I'm always open to rename it to a singular.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants