Use QBrush when returning background color

migaku-official · Jun 26, 2023 · 7414a6d · 7414a6d
1 parent 56abdd6
commit 7414a6d
Showing 1 changed file with 4 additions and 1 deletion.
diff --git a/addon/kanji_confirm_dialog.py b/addon/kanji_confirm_dialog.py
@@ -13,6 +13,7 @@
     QModelIndex,
     QVariant,
     QVBoxLayout,
+    QBrush,
 )
 
 from . import util
@@ -53,10 +54,12 @@ def data(self, idx, role):
         kanji = self.kanji[idx.row()]
 
         if role == Qt.ItemDataRole.DisplayRole:
+            # This should be a QBrush, but we also use the method
             return str(kanji)
         if role == Qt.ItemDataRole.BackgroundRole:
             state = self.states[kanji]
-            return QColor(self.state_colors[state])
+            return QBrush(QColor(self.state_colors[state]))
+
         return QVariant()
 
     def rowCount(self, _parent):