Skip to content

Sankaku new tags system #7333

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wankio opened this issue Apr 9, 2025 · 13 comments
Closed

Sankaku new tags system #7333

wankio opened this issue Apr 9, 2025 · 13 comments

Comments

@wankio
Copy link
Contributor

wankio commented Apr 9, 2025

Today I just ran chan.sankaku and found out it has a completely new tag system. Now it has organized tag groups, which are pretty damn good:
https://imgur.com/a/yYAh1KY

But it looks like gallery-dl doesn't support it yet.

@mikf
Copy link
Owner

mikf commented Apr 9, 2025

Enabling the tags option should provide at least some tag categorization.

@wankio
Copy link
Contributor Author

wankio commented Apr 9, 2025

yes i enabled it very long time ago,

tags_artist
tag_string
tag_string_character
tag_string_copyright
tag_string_general
tag_string_genre
tag_string_medium

tags[N]
tags_character[N]
tags_copyright[N]
tags_general[N]
tags_genre[N]
tags_medium[N]

but new tags system is so good, hope it get updated soon

@taskhawk
Copy link

For my part, I would prefer that if support for the new tag categories is implemented at least there's a config option to keep using the current ones because they are the same or very similar to the categories other boorus sites are already using and merging the tags from all sites based on file checksum (MD5) is easier that way than dealing with the large amount of new categories Sankaku introduced.

@HASTJI
Copy link

HASTJI commented Apr 30, 2025

but new tags system is so good, hope it get updated soon

Hope they add some sort of option to select which tags( I mean categories of them) download and which category to ignore while saving tags in file. For example save only tags from Anatomy, Pose, Action and Cloth and totally ignore other one. I know that there is --filter function, but can't figure out how to use it better to setup it. Also it will be very usefull if there will be option to add marker for each tag which category it's in, something like "[Pose] Sitting".

@alfa-147
Copy link

These new categories are better organized, but many people may prefer the system used so far. For this reason, I suggest implementing an option in the configuration file like this:

"enable-new-categories": false / true

for those who wish to keep it unchanged, the value false provides the old tag system similarly shared by other booru sites;
for those who want the new category tag system, adopted exclusively by Sankaku, choose the value true.

An other request related to the new tag system is the possibility to filter them during the export post-process. I think a
blacklist/whitelist is the most suitable option to handle this part.

@HASTJI
Copy link

HASTJI commented May 22, 2025

These new categories are better organized, but many people may prefer the system used so far.

Is those categories already implemented in fresh builds? I can't figure out how to enable it and write tags to file with categories enabled.

@alfa-147
Copy link

alfa-147 commented May 22, 2025

No, you misunderstood my post. I was just suggesting a possible solution to implement, not a feature already present in Gallery-dl. However, I already asked mikf about it and he confirmed that the new tag system will eventually be implemented in future but not planned with this method.
Here the link: #7553

@mikf
Copy link
Owner

mikf commented May 22, 2025

Added support in 7b5dd61

You need to set tags to "extended" to enable this feature
and provide logged-in cookies for sankaku to display all categorized tags.

@mikf mikf closed this as completed May 23, 2025
@alfa-147
Copy link

Sorry to reopen this thread, but something is wrong.
I've enabled the feature "extended" and provided cookies but when exporting metadata only a very limited amount of tags will be exported, completely ignoring the rest.
example: SFW
This is the only additionally exported categorized tag with 2 tags (while in reality "tags_fashion" has 18 tags):

"tags_fashion":
        "bangs",
        "bare_shoulders"

All the other categorized tag (Anatomy, Pose, Action,...) are completely ignored from the exporting.
In case I'm importing cookies wrongly, here my configuration:

"sankaku": {
       "username": "****",
       "password": "****",
       "tags": "extended",
       "cookies": ["firefox", null, null, null, ".sankakucomplex.com"],

@mikf mikf reopened this May 23, 2025
@HASTJI
Copy link

HASTJI commented May 23, 2025

Sorry to reopen this thread, but something is wrong.
I've enabled the feature "extended" and provided cookies but when exporting metadata only a very limited amount of tags will be exported, completely ignoring the rest.
example: SFW
This is the only additionally exported categorized tag with 2 tags (while in reality "tags_fashion" has 18 tags):

"tags_fashion":
        "bangs",
        "bare_shoulders"

All the other categorized tag (Anatomy, Pose, Action,...) are completely ignored from the exporting.
In case I'm importing cookies wrongly, here my configuration:

"sankaku": {
       "username": "****",
       "password": "****",
       "tags": "extended",
       "cookies": ["firefox", null, null, null, ".sankakucomplex.com"],

Any post ID on which you encountered this problem? Just as a reference for future tests.

@mikf
Copy link
Owner

mikf commented May 23, 2025

Found the issue. This line prevents cookies from being loaded and I somehow missed this.
Just delete it and it'll categorize all tags.

cookies_domain = None

@alfa-147
Copy link

I'm using the .exe version of Gallery-dl, so I'll just have to wait for the fix.

mikf added a commit that referenced this issue May 24, 2025
to allow '"tags": "extended"' to work properly
@mikf
Copy link
Owner

mikf commented May 24, 2025

@mikf mikf closed this as completed May 24, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

5 participants