Fix adapter generateIdForRecord signature (#294)

charlesfries · web-flow · commit 2da2da6de8dd · 2024-04-22T15:22:31.000-07:00
diff --git a/addon/adapters/cloud-firestore-modular.ts b/addon/adapters/cloud-firestore-modular.ts
@@ -82,10 +82,9 @@ export default class CloudFirestoreModularAdapter extends Adapter {
     return fastboot && fastboot.isFastBoot;
   }
 
-  // @ts-expect-error EmberData types incorrect
-  public generateIdForRecord(_store: Store, type: string): string {
+  public generateIdForRecord(_store: Store, type: unknown): string {
     const db = getFirestore();
-    const collectionName = buildCollectionName(type);
+    const collectionName = buildCollectionName(type as string); // TODO: EmberData types incorrect
 
     return doc(collection(db, collectionName)).id;
   }

Original file line number	Diff line number	Diff line change
`@@ -82,10 +82,9 @@ export default class CloudFirestoreModularAdapter extends Adapter {`
`82`	`82`	`return fastboot && fastboot.isFastBoot;`
`83`	`83`	`}`
`84`	`84`
`85`		`- // @ts-expect-error EmberData types incorrect`
`86`		`- public generateIdForRecord(_store: Store, type: string): string {`
	`85`	`+ public generateIdForRecord(_store: Store, type: unknown): string {`
`87`	`86`	`const db = getFirestore();`
`88`		`- const collectionName = buildCollectionName(type);`
	`87`	`+ const collectionName = buildCollectionName(type as string); // TODO: EmberData types incorrect`
`89`	`88`
`90`	`89`	`return doc(collection(db, collectionName)).id;`
`91`	`90`	`}`