Skip to content

Commit 857b1cd

Browse files
committed
Merge branch 'master' into remove-ect
# Conflicts: # ember-cli-build.js # package-lock.json # package.json
2 parents 7d47ccf + 1b2f830 commit 857b1cd

Some content is hidden

Large Commits have some content hidden by default. Use the searchbox below for content that may be hidden.

68 files changed

+61638
-41974
lines changed

.ember-cli

+1-9
Original file line numberDiff line numberDiff line change
@@ -1,15 +1,7 @@
11
{
2-
/**
3-
Ember CLI sends analytics information by default. The data is completely
4-
anonymous, but there are times when you might want to disable this behavior.
5-
6-
Setting `disableAnalytics` to true will prevent any data from being sent.
7-
*/
8-
"disableAnalytics": false,
9-
102
/**
113
Setting `isTypeScriptProject` to true will force the blueprint generators to generate TypeScript
124
rather than JavaScript by default, when a TypeScript version of a given blueprint is available.
135
*/
14-
"isTypeScriptProject": false
6+
"isTypeScriptProject": true
157
}

.eslintignore

+1-26
Original file line numberDiff line numberDiff line change
@@ -1,40 +1,15 @@
11
# unconventional js
22
/blueprints/*/files/
3-
/vendor/
43

54
# compiled output
65
/dist/
7-
/tmp/
8-
9-
# dependencies
10-
/bower_components/
11-
/node_modules/
126

137
# misc
148
/coverage/
159
!.*
1610
.*/
17-
.eslintcache
1811

1912
# ember-try
2013
/.node_modules.ember-try/
21-
/bower.json.ember-try
22-
/npm-shrinkwrap.json.ember-try
23-
/package.json.ember-try
24-
/package-lock.json.ember-try
25-
/yarn.lock.ember-try
26-
27-
# ember generated files
28-
ember-cli-build.js
29-
index.js
30-
testem.js
31-
config/*.js
32-
tests/*.js
33-
tests/dummy/*.js
34-
tests/dummy/app/*.js
35-
tests/dummy/config/*.js
3614

37-
# ember-cli-typescript generated files
38-
tests/dummy/app/config/environment.d.ts
39-
types/dummy/index.d.ts
40-
types/global.d.ts
15+
/addon/firebase/

.eslintrc.js

+44-34
Original file line numberDiff line numberDiff line change
@@ -1,25 +1,17 @@
1-
/* eslint-disable */
2-
31
'use strict';
42

53
module.exports = {
64
root: true,
75
parser: '@typescript-eslint/parser',
86
parserOptions: {
9-
ecmaVersion: 2018,
10-
sourceType: 'module',
11-
ecmaFeatures: {
12-
legacyDecorators: true,
13-
},
7+
ecmaVersion: 'latest',
148
},
15-
plugins: [
16-
'@typescript-eslint',
17-
'ember',
18-
],
9+
plugins: ['ember', '@typescript-eslint'],
1910
extends: [
2011
'airbnb-base',
21-
'plugin:@typescript-eslint/recommended',
12+
'eslint:recommended',
2213
'plugin:ember/recommended',
14+
'plugin:prettier/recommended',
2315
],
2416
env: {
2517
browser: true,
@@ -30,36 +22,49 @@ module.exports = {
3022
settings: {
3123
'import/resolver': {
3224
node: {
33-
extensions: ['.mjs', '.js', '.json', '.ts']
34-
}
25+
extensions: ['.mjs', '.js', '.json', '.ts'],
26+
},
3527
},
36-
'import/extensions': [
37-
'.js',
38-
'.mjs',
39-
'.jsx',
40-
'.ts',
41-
],
28+
'import/extensions': ['.js', '.mjs', '.jsx', '.ts'],
4229
},
4330
rules: {
44-
'semi': 'off', // enforced by @typescript-eslint/semi
31+
semi: 'off', // enforced by @typescript-eslint/semi
4532
'import/no-unresolved': 'off',
4633
'import/no-extraneous-dependencies': 'off',
47-
'import/extensions': ['error', 'ignorePackages', {
48-
js: 'never',
49-
mjs: 'never',
50-
jsx: 'never',
51-
ts: 'never',
52-
}],
34+
'import/extensions': [
35+
'error',
36+
'ignorePackages',
37+
{
38+
js: 'never',
39+
mjs: 'never',
40+
jsx: 'never',
41+
ts: 'never',
42+
},
43+
],
5344
'class-methods-use-this': 'off',
5445
'no-underscore-dangle': 'off',
5546
'ember/use-ember-data-rfc-395-imports': 'off',
47+
'no-restricted-exports': 'off',
48+
'lines-between-class-members': 'off',
49+
'array-callback-return': 'off',
50+
'func-names': 'off',
5651
},
5752
overrides: [
53+
// ts files
54+
{
55+
files: ['**/*.ts'],
56+
extends: [
57+
'plugin:@typescript-eslint/eslint-recommended',
58+
'plugin:@typescript-eslint/recommended',
59+
],
60+
rules: {},
61+
},
5862
// node files
5963
{
6064
files: [
6165
'./.eslintrc.js',
6266
'./.prettierrc.js',
67+
'./.stylelintrc.js',
6368
'./.template-lintrc.js',
6469
'./ember-cli-build.js',
6570
'./index.js',
@@ -75,18 +80,23 @@ module.exports = {
7580
browser: false,
7681
node: true,
7782
},
78-
plugins: ['node'],
79-
extends: ['plugin:node/recommended']
83+
extends: ['plugin:n/recommended'],
84+
rules: {
85+
'global-require': 'off',
86+
'prefer-object-spread': 'off',
87+
'prefer-rest-params': 'off',
88+
strict: 'off',
89+
'n/no-extraneous-require': 'off',
90+
},
8091
},
8192
{
8293
// test files
8394
files: ['tests/**/*-test.{js,ts}'],
8495
extends: ['plugin:qunit/recommended'],
8596
rules: {
8697
'prefer-arrow-callback': 'off',
87-
'func-names': 'off',
88-
'@typescript-eslint/no-empty-function': 'off'
89-
}
90-
}
91-
]
98+
'qunit/require-expect': 'off',
99+
},
100+
},
101+
],
92102
};

.github/workflows/ci.yml

+8-6
Original file line numberDiff line numberDiff line change
@@ -15,13 +15,14 @@ jobs:
1515
test:
1616
name: "Tests"
1717
runs-on: ubuntu-latest
18+
timeout-minutes: 10
1819

1920
steps:
2021
- uses: actions/checkout@v3
2122
- name: Install Node
2223
uses: actions/setup-node@v3
2324
with:
24-
node-version: 16.x
25+
node-version: 18
2526
cache: npm
2627
- name: Install Dependencies
2728
run: npm ci
@@ -33,12 +34,13 @@ jobs:
3334
floating:
3435
name: "Floating Dependencies"
3536
runs-on: ubuntu-latest
37+
timeout-minutes: 10
3638

3739
steps:
3840
- uses: actions/checkout@v3
3941
- uses: actions/setup-node@v3
4042
with:
41-
node-version: 16.x
43+
node-version: 18
4244
cache: npm
4345
- name: Install Dependencies
4446
run: npm install --no-shrinkwrap
@@ -49,17 +51,17 @@ jobs:
4951
name: ${{ matrix.try-scenario }}
5052
runs-on: ubuntu-latest
5153
needs: "test"
54+
timeout-minutes: 10
5255

5356
strategy:
5457
fail-fast: false
5558
matrix:
5659
try-scenario:
57-
- ember-lts-3.24
58-
- ember-lts-3.28
60+
- ember-lts-4.8
61+
- ember-lts-4.12
5962
- ember-release
6063
- ember-beta
6164
- ember-canary
62-
- ember-classic
6365
- embroider-safe
6466
- embroider-optimized
6567

@@ -68,7 +70,7 @@ jobs:
6870
- name: Install Node
6971
uses: actions/setup-node@v3
7072
with:
71-
node-version: 16.x
73+
node-version: 18
7274
cache: npm
7375
- name: Install Dependencies
7476
run: npm ci

.gitignore

+1-8
Original file line numberDiff line numberDiff line change
@@ -1,21 +1,15 @@
1-
# See https://help.github.com/ignore-files/ for more about ignoring files.
2-
31
# compiled output
42
/dist/
5-
/tmp/
3+
/declarations/
64

75
# dependencies
8-
/bower_components/
96
/node_modules/
107

118
# misc
129
/.env*
1310
/.pnp*
14-
/.sass-cache
1511
/.eslintcache
16-
/connect.lock
1712
/coverage/
18-
/libpeerconnection.log
1913
/npm-debug.log*
2014
/testem.log
2115
/yarn-error.log
@@ -26,7 +20,6 @@ vim.exe.stackdump
2620

2721
# ember-try
2822
/.node_modules.ember-try/
29-
/bower.json.ember-try
3023
/npm-shrinkwrap.json.ember-try
3124
/package.json.ember-try
3225
/package-lock.json.ember-try

.npmignore

+2-7
Original file line numberDiff line numberDiff line change
@@ -2,11 +2,7 @@
22
/dist/
33
/tmp/
44

5-
# dependencies
6-
/bower_components/
7-
85
# misc
9-
/.bowerrc
106
/.editorconfig
117
/.ember-cli
128
/.env*
@@ -18,11 +14,11 @@
1814
/.gitignore
1915
/.prettierignore
2016
/.prettierrc.js
17+
/.stylelintignore
18+
/.stylelintrc.js
2119
/.template-lintrc.js
2220
/.travis.yml
2321
/.watchmanconfig
24-
/bower.json
25-
/config/ember-try.js
2622
/CONTRIBUTING.md
2723
/ember-cli-build.js
2824
/testem.js
@@ -33,7 +29,6 @@
3329

3430
# ember-try
3531
/.node_modules.ember-try/
36-
/bower.json.ember-try
3732
/npm-shrinkwrap.json.ember-try
3833
/package.json.ember-try
3934
/package-lock.json.ember-try

.prettierignore

+1-13
Original file line numberDiff line numberDiff line change
@@ -1,25 +1,13 @@
11
# unconventional js
22
/blueprints/*/files/
3-
/vendor/
43

54
# compiled output
65
/dist/
7-
/tmp/
8-
9-
# dependencies
10-
/bower_components/
11-
/node_modules/
126

137
# misc
148
/coverage/
159
!.*
16-
.eslintcache
17-
.lint-todo/
10+
.*/
1811

1912
# ember-try
2013
/.node_modules.ember-try/
21-
/bower.json.ember-try
22-
/npm-shrinkwrap.json.ember-try
23-
/package.json.ember-try
24-
/package-lock.json.ember-try
25-
/yarn.lock.ember-try

.prettierrc.js

+8-3
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,12 @@
1-
/* eslint-disable */
2-
31
'use strict';
42

53
module.exports = {
6-
singleQuote: true,
4+
overrides: [
5+
{
6+
files: '*.{js,ts}',
7+
options: {
8+
singleQuote: true,
9+
},
10+
},
11+
],
712
};

.stylelintignore

+8
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,8 @@
1+
# unconventional files
2+
/blueprints/*/files/
3+
4+
# compiled output
5+
/dist/
6+
7+
# addons
8+
/.node_modules.ember-try/

.stylelintrc.js

+5
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,5 @@
1+
'use strict';
2+
3+
module.exports = {
4+
extends: ['stylelint-config-standard', 'stylelint-prettier/recommended'],
5+
};

.template-lintrc.js

-2
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,3 @@
1-
/* eslint-disable */
2-
31
'use strict';
42

53
module.exports = {

.watchmanconfig

+1-1
Original file line numberDiff line numberDiff line change
@@ -1,3 +1,3 @@
11
{
2-
"ignore_dirs": ["tmp", "dist"]
2+
"ignore_dirs": ["dist"]
33
}

README.md

+4-3
Original file line numberDiff line numberDiff line change
@@ -20,11 +20,12 @@ In order to continue development with Ember and Cloud Firestore, I had to build
2020

2121
## Compatibility
2222

23-
* Ember.js v3.24 or above
24-
* Ember CLI v3.24 or above
25-
* Node.js v12 or above
23+
* Ember.js v4.8 or above
24+
* Ember CLI v4.8 or above
25+
* Node.js v18 or above
2626
* Firebase v9.14.x
2727

28+
2829
## Installation
2930

3031
This addon requires some peer dependencies. Install the correct versions of each package, which are listed by the command:

0 commit comments

Comments
 (0)