Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: use keyof ModelRegistry for modelName to fix type issues when any index is removed from registry #288

Closed
wants to merge 3 commits into from
Closed

fix: use keyof ModelRegistry for modelName to fix type issues when any index is removed from registry #288

Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
519cc58
Generics
charlesfries Apr 22, 2024
2cdfcdd
Remove comment
charlesfries Apr 22, 2024
2d24f46
Merge branch 'master' into fix-modelregistry-any
charlesfries Apr 22, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Remove comment
  • Loading branch information
@charlesfries
charlesfries committed Apr 22, 2024
commit 2cdfcdd62bf324d4d1bc20644313bd30fb0b1f36
1 change: 0 additions & 1 deletion addon/adapters/cloud-firestore-modular.ts
View file
Original file line number Diff line number Diff line change
@@ -86,7 +86,6 @@ export default class CloudFirestoreModularAdapter extends Adapter {
return fastboot && fastboot.isFastBoot;
}

// @ts-expect-error EmberData types are incorrect
public generateIdForRecord(_store: Store, type: string): string {
const db = getFirestore();
const collectionName = buildCollectionName(type);
Loading