Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: update to ember 6 #329

Closed
wants to merge 3 commits into from
Closed
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions .eslintignore
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,7 @@
/blueprints/*/files/

# compiled output
/declarations/
/dist/

# misc
Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/ci.yml
Original file line number Diff line number Diff line change
Expand Up @@ -57,8 +57,8 @@ jobs:
fail-fast: false
matrix:
try-scenario:
- ember-lts-4.8
- ember-lts-4.12
- ember-lts-5.4
- ember-release
- ember-beta
- ember-canary
Expand Down
2 changes: 2 additions & 0 deletions .npmignore
Original file line number Diff line number Diff line change
Expand Up @@ -23,6 +23,8 @@
/ember-cli-build.js
/testem.js
/tests/
/tsconfig.declarations.json
/tsconfig.json
/yarn-error.log
/yarn.lock
.gitkeep
Expand Down
16 changes: 8 additions & 8 deletions CONTRIBUTING.md
Original file line number Diff line number Diff line change
Expand Up @@ -3,23 +3,23 @@
## Installation

* `git clone <repository-url>`
* `cd my-addon`
* `cd ember-cloud-firestore-adapter`
* `npm install`

## Linting

* `npm run lint`
* `npm run lint:fix`
- `npm run lint`
- `npm run lint:fix`

## Running tests

* `ember test` – Runs the test suite on the current Ember version
* `ember test --server` – Runs the test suite in "watch mode"
* `ember try:each` – Runs the test suite against multiple Ember versions
- `npm run test` – Runs the test suite on the current Ember version
- `npm run test:ember -- --server` – Runs the test suite in "watch mode"
- `npm run test:ember-compatibility` – Runs the test suite against multiple Ember versions

## Running the dummy application

* `ember serve`
* Visit the dummy application at [http://localhost:4200](http://localhost:4200).
- `npm run start`
- Visit the dummy application at [http://localhost:4200](http://localhost:4200).

For more information on using ember-cli, visit [https://cli.emberjs.com/release/](https://cli.emberjs.com/release/).
12 changes: 5 additions & 7 deletions README.md
Original file line number Diff line number Diff line change
Expand Up @@ -20,10 +20,10 @@ In order to continue development with Ember and Cloud Firestore, I had to build

## Compatibility

* Ember.js v4.8 or above
* Ember CLI v4.8 or above
* Node.js v18 or above
* Firebase v9.14.x
- Ember.js v4.12 or above
- Ember CLI v4.12 or above
- Node.js v18 or above
- Firebase v9.14.x


## Installation
Expand All @@ -40,16 +40,14 @@ Once you've installed it, you can now install the addon itself:
ember install ember-cloud-firestore-adapter
```

Getting Started
------------------------------------------------------------------------------
## Usage

Checkout the docs [here](docs/getting-started.md).

## Contributing

See the [Contributing](CONTRIBUTING.md) guide for details.


## License

This project is licensed under the [MIT License](LICENSE.md).
2 changes: 1 addition & 1 deletion addon/adapters/cloud-firestore-modular.ts
Original file line number Diff line number Diff line change
Expand Up @@ -67,7 +67,7 @@ interface HasManyRelationshipMeta {

export default class CloudFirestoreAdapter extends Adapter {
@service('-firestore-data-manager')
protected declare firestoreDataManager: FirestoreDataManager;
declare protected firestoreDataManager: FirestoreDataManager;

protected referenceKeyName = 'referenceTo';

Expand Down
2 changes: 1 addition & 1 deletion addon/services/-firestore-data-manager.ts
Original file line number Diff line number Diff line change
Expand Up @@ -59,7 +59,7 @@ interface HasManyFetchConfig {

export default class FirestoreDataManager extends Service {
@service
private declare store: StoreService;
declare private store: StoreService;

private docListeners: DocListeners = {};

Expand Down
Loading
Loading