Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: update to ember 5.7.0 #333

Merged
merged 5 commits into from
Feb 20, 2025
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions CONTRIBUTING.md
Original file line number Diff line number Diff line change
Expand Up @@ -13,13 +13,13 @@

## Running tests

* `ember test` – Runs the test suite on the current Ember version
* `ember test --server` – Runs the test suite in "watch mode"
* `ember try:each` – Runs the test suite against multiple Ember versions
* `npm run test` – Runs the test suite on the current Ember version
* `npm run test:ember -- --server` – Runs the test suite in "watch mode"
* `npm run test:ember-compatibility` – Runs the test suite against multiple Ember versions

## Running the dummy application

* `ember serve`
* `npm run start`
* Visit the dummy application at [http://localhost:4200](http://localhost:4200).

For more information on using ember-cli, visit [https://cli.emberjs.com/release/](https://cli.emberjs.com/release/).
4 changes: 2 additions & 2 deletions addon/adapters/cloud-firestore-modular.ts
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
import { getOwner } from '@ember/owner';
import { getOwner } from '@ember/application';
import { service } from '@ember/service';
import Adapter from '@ember-data/adapter';
import type { ModelSchema } from '@ember-data/store/types';
Expand Down Expand Up @@ -74,7 +74,7 @@ export type LegacyHasManyField = _LegacyHasManyField & {

export default class CloudFirestoreAdapter extends Adapter {
@service('-firestore-data-manager')
protected declare firestoreDataManager: FirestoreDataManager;
declare protected firestoreDataManager: FirestoreDataManager;

protected referenceKeyName = 'referenceTo';

Expand Down
4 changes: 3 additions & 1 deletion addon/services/-firestore-data-manager.ts
Original file line number Diff line number Diff line change
Expand Up @@ -61,7 +61,7 @@ interface HasManyFetchConfig {

export default class FirestoreDataManager extends Service {
@service
private declare store: StoreService;
declare private store: StoreService;

private docListeners: DocListeners = {};

Expand Down Expand Up @@ -375,6 +375,7 @@ export default class FirestoreDataManager extends Service {
// in the query array while the record is being unloaded from store can cause an error.
// To avoid the issue, we run .update() in the next runloop so that we allow the unload
// to happen first.
// eslint-disable-next-line ember/no-runloop
next(() => {
// In case multiple docs within the query were updated, this block can potentially happen
// multiple times. Race condition can happen where queryId no longer exists inside
Expand Down Expand Up @@ -415,6 +416,7 @@ export default class FirestoreDataManager extends Service {
// in the hasMany array while the record is being unloaded from store can cause an error.
// To avoid the issue, we run .reload() in the next runloop so that we allow the unload
// to happen first.
// eslint-disable-next-line ember/no-runloop
next(() => {
const record = this.store.peekRecord(config.modelName, config.id);
const hasManyRef = (record as Model).hasMany(config.field);
Expand Down
Loading