Skip to content

Commit e0d5cf7

Browse files
authored
enhance: Use hyphen instead of underscore in grpc header (#2730)
Related to milvus-io/milvus#41357 Signed-off-by: Congqi Xia <congqi.xia@zilliz.com>
1 parent 7a5e3f4 commit e0d5cf7

File tree

3 files changed

+5
-5
lines changed

3 files changed

+5
-5
lines changed

pymilvus/client/async_grpc_handler.py

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -199,13 +199,13 @@ def _setup_grpc_channel(self, **kwargs):
199199
self._final_channel._unary_unary_interceptors.append(async_db_interceptor)
200200
if self._log_level:
201201
async_log_level_interceptor = async_header_adder_interceptor(
202-
["log_level"], [self._log_level]
202+
["log-level"], [self._log_level]
203203
)
204204
self._final_channel._unary_unary_interceptors.append(async_log_level_interceptor)
205205
self._log_level = None
206206
if self._request_id:
207207
async_request_id_interceptor = async_header_adder_interceptor(
208-
["client_request_id"], [self._request_id]
208+
["client-request-id"], [self._request_id]
209209
)
210210
self._final_channel._unary_unary_interceptors.append(async_request_id_interceptor)
211211
self._request_id = None

pymilvus/client/grpc_handler.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -259,7 +259,7 @@ def _setup_grpc_channel(self):
259259
self._log_level = None
260260
if self._request_id:
261261
request_id_interceptor = interceptor.header_adder_interceptor(
262-
["client_request_id"], [self._request_id]
262+
["client-request-id"], [self._request_id]
263263
)
264264
self._final_channel = grpc.intercept_channel(
265265
self._final_channel, request_id_interceptor

pymilvus/decorators.py

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -167,8 +167,8 @@ def tracing_request():
167167
def wrapper(func: Callable):
168168
@functools.wraps(func)
169169
def handler(self: Callable, *args, **kwargs):
170-
level = kwargs.get("log_level")
171-
req_id = kwargs.get("client_request_id")
170+
level = kwargs.get("log-level", kwargs.get("log_level"))
171+
req_id = kwargs.get("client-request-id", kwargs.get("client_request_id"))
172172
if level:
173173
self.set_onetime_loglevel(level)
174174
if req_id:

0 commit comments

Comments
 (0)