fix: Pass request-id in metadata per API #2766
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: XuanYang-cn The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
client-request-id is used to trace each API, and unique for each API. The previous code resets the channel for every API call to set it into global channel interceptor, which has great performance down and also will rewrite each other. This PR adds client-request-id to per API metadata, and remove some of the future calls. See also: milvus-io#2761, milvus-io#2765 Signed-off-by: yangxuan <xuan.yang@zilliz.com>
XuanYang-cn
force-pushed
the
fix-request-id
branch
from
df4c8ef to
0ca117b
Compare
XuanYang-cn
added
the
PR | need to cherry-pick to 2.x
|
@Mergifyio refresh |
✅ Pull request refreshed |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
client-request-id is used to trace each API, and unique for each API. The previous code resets the channel for every API call to set it into global channel interceptor, which has great performance down and also will rewrite each other.
This PR adds client-request-id to per API metadata, and remove some of
the future calls.
See also: #2761, #2765