Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updated the Mandatory Parameters and Initialization Logic #2

Merged
merged 18 commits into from
Jan 16, 2025

Conversation

MinuraPunchihewa
Copy link
Contributor

@MinuraPunchihewa MinuraPunchihewa commented Jan 13, 2025

This PR makes the following improvements:

  • Makes the name parameter mandatory for both data sources and Minds to avoid creating random names each time either of them are initialized.
  • Allows re-use of existing data sources and Minds by providing only the name.
  • Moves the initialization logic for data sources to AIMindDataSource for improved modularity.
  • Enables credentials for data sources to be configured via environment variables using the AIMindEnvVar class.
  • Improves the docstrings for the classes and their methods.

The documentation and tests are yet to be updated based on these changes.

except ObjectNotFound:
# If the parameters for creating the data source are not provided,
# raise an error.
if not self.engine or not self.description or not self.connection_data:
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

description is not mandatory for datasource creation

Copy link
Contributor Author

@MinuraPunchihewa MinuraPunchihewa Jan 16, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You're right, I can see that here, but it's marked as required in our docs and in our front-end as well, I believe.

I will fix the docs.

@MinuraPunchihewa MinuraPunchihewa merged commit 9485319 into main Jan 16, 2025
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants