-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Updated the Mandatory Parameters and Initialization Logic #2
Merged
MinuraPunchihewa
merged 18 commits into
main
from
feature/mandatory_names_and_other_improvements
Jan 16, 2025
Merged
Updated the Mandatory Parameters and Initialization Logic #2
MinuraPunchihewa
merged 18 commits into
main
from
feature/mandatory_names_and_other_improvements
Jan 16, 2025
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
StpMax
approved these changes
Jan 15, 2025
langchain_minds/tools.py
Outdated
except ObjectNotFound: | ||
# If the parameters for creating the data source are not provided, | ||
# raise an error. | ||
if not self.engine or not self.description or not self.connection_data: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
description is not mandatory for datasource creation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR makes the following improvements:
AIMindDataSource
for improved modularity.AIMindEnvVar
class.The documentation and tests are yet to be updated based on these changes.