Upsert minds/datasources #44
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
StpMax
approved these changes
Oct 23, 2024
minds/datasources/datasources.py
Outdated
| class Datasources: | ||
| def __init__(self, client): | ||
| self.api = client.api | ||
|
|
||
| def create(self, ds_config: DatabaseConfig, replace=False): | ||
| def create(self, ds_config: DatabaseConfig, replace=False, update=False): |
There was a problem hiding this comment.
I don't like the word 'replace' here. Without code inspection i can't predict what would happen if set this option to 'true'. For example, if i have mind 'X' with attached datasource 'Y', and then call datasource.create('Y', replace=True), then datasource 'Y' will be detached from mind 'X'. It does't look like 'replace'.
The presence of two options 'replace' and 'update' also make behavior undefined. What if i set both to 'true'?
Better will be to split this into two methods without 'replace' or 'update' arguments:
- create - raise error if ds exists
- upsert - update if exists, create otherwise
There was a problem hiding this comment.
I will remove 'replace' parameter
| @@ -53,6 +53,16 @@ def post(self, url, data): | |||
| _raise_for_status(resp) | |||
| return resp | |||
|
|
|||
| def put(self, url, data): | |||
| resp = requests.put( | |||
| self.base_url + url, | |||
There was a problem hiding this comment.
safer to use urllib.parse.urljoin
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added update parameter for minds.create and datasources.create.
If it is set: mind or datasource will be updated if it is exist
Dependent on https://github.com/mindsdb/mindsdb_gateway/pull/956