Skip to content

Commit d82cd2e

Browse files
authored
Merge branch 'main' into user-guide
2 parents 7cb7c58 + 108d5e8 commit d82cd2e

File tree

7 files changed

+24
-23
lines changed

7 files changed

+24
-23
lines changed

.devcontainer/devcontainer-lock.json

+3-3
Original file line numberDiff line numberDiff line change
@@ -1,9 +1,9 @@
11
{
22
"features": {
33
"ghcr.io/devcontainers/features/docker-in-docker:2": {
4-
"version": "2.10.2",
5-
"resolved": "ghcr.io/devcontainers/features/docker-in-docker@sha256:23ae11a86089da5f0b98a6edd603f91831802b7f2d5ef1e104e1b94a3beb546c",
6-
"integrity": "sha256:23ae11a86089da5f0b98a6edd603f91831802b7f2d5ef1e104e1b94a3beb546c"
4+
"version": "2.11.0",
5+
"resolved": "ghcr.io/devcontainers/features/docker-in-docker@sha256:503f23cd692325b3cbb8c20a0ecfabb3444b0c786b363e0c82572bd7d71dc099",
6+
"integrity": "sha256:503f23cd692325b3cbb8c20a0ecfabb3444b0c786b363e0c82572bd7d71dc099"
77
},
88
"ghcr.io/devcontainers/features/node:1": {
99
"version": "1.4.1",

.github/workflows/super-linter.yml

+1-1
Original file line numberDiff line numberDiff line change
@@ -29,7 +29,7 @@ jobs:
2929

3030
- name: Super-Linter
3131
id: super_linter
32-
uses: super-linter/super-linter/slim@4758be622215d0954c8353ee4877ffd60111cf8e # v6.4.1
32+
uses: super-linter/super-linter/slim@56576d491db07c7236b445ab09991ca49d12b0c6 # v6.5.0
3333
env:
3434
GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }}
3535
DEFAULT_BRANCH: main

images/base/CHANGELOG.md

+7
Original file line numberDiff line numberDiff line change
@@ -8,6 +8,13 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0
88

99
## [Unreleased]
1010

11+
## [2.0.0] - 2024-05-13
12+
13+
### Changed
14+
15+
- Updated image to Ubuntu 24.04
16+
- Updated references to `1000`, `vscode` user is now `1001`
17+
1118
## [1.0.0] - 2024-04-16
1219

1320
### Changed

images/base/Dockerfile

+2-8
Original file line numberDiff line numberDiff line change
@@ -2,7 +2,7 @@
22
#checkov:skip=CKV_DOCKER_3: USER not required - A non-root user is created, and used by VS Code's Remote Containers extension
33
# hadolint global ignore=DL3008,DL3013
44

5-
FROM mcr.microsoft.com/devcontainers/base:ubuntu-22.04
5+
FROM mcr.microsoft.com/devcontainers/base:ubuntu-24.04
66

77
LABEL org.opencontainers.image.vendor="Ministry of Justice" \
88
org.opencontainers.image.authors="Dev Container Community" \
@@ -22,16 +22,13 @@ apt-get update --yes
2222

2323
apt-get upgrade --yes
2424

25-
apt-get install --yes --no-install-recommends \
25+
apt-get install --yes \
2626
python3-pip
2727

2828
apt-get clean --yes
2929

3030
rm --force --recursive /var/lib/apt/lists/*
3131

32-
python3 -m pip install --no-cache-dir --upgrade \
33-
pip
34-
3532
chsh --shell "$(which zsh)" vscode
3633

3734
cat /home/vscode/.zshrc.snippet >> /home/vscode/.zshrc
@@ -56,7 +53,4 @@ apt-get upgrade --yes
5653
apt-get clean --yes
5754

5855
rm --force --recursive /var/lib/apt/lists/*
59-
60-
python3 -m pip install --no-cache-dir --upgrade \
61-
pip
6256
EOF

images/base/config.json

+1-1
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,4 @@
11
{
22
"name": "base",
3-
"version": "1.0.0"
3+
"version": "2.0.0"
44
}

images/base/src/usr/local/bin/devcontainer-utils

+1-1
Original file line numberDiff line numberDiff line change
@@ -77,5 +77,5 @@ apt_install() {
7777
pip_install() {
7878
local packages="${1}"
7979

80-
python3 -m pip install --no-cache-dir --upgrade "${packages}"
80+
python3 -m pip install --no-cache-dir --upgrade --break-system-packages "${packages}"
8181
}

images/base/test/container-structure-test.yml

+9-9
Original file line numberDiff line numberDiff line change
@@ -5,17 +5,17 @@ commandTests:
55
- name: "vscode user"
66
command: "id"
77
args: ["--user", "vscode"]
8-
expectedOutput: ["1000"]
8+
expectedOutput: ["1001"]
99

1010
- name: "vscode group"
1111
command: "id"
1212
args: ["--group", "vscode"]
13-
expectedOutput: ["1000"]
13+
expectedOutput: ["1001"]
1414

1515
- name: "vscode user getent"
1616
command: "getent"
1717
args: ["passwd", "vscode" ]
18-
expectedOutput: ["vscode:x:1000:1000::/home/vscode:/usr/bin/zsh"]
18+
expectedOutput: ["vscode:x:1001:1001::/home/vscode:/usr/bin/zsh"]
1919

2020
- name: "pip"
2121
command: "pip"
@@ -41,22 +41,22 @@ fileExistenceTests:
4141
path: "/home/vscode/.oh-my-zsh/custom/themes/devcontainers.zsh-theme"
4242
shouldExist: true
4343
permissions: "-rwxr-xr-x" # 0755
44-
uid: 1000
45-
gid: 1000
44+
uid: 1001
45+
gid: 1001
4646

4747
- name: "featurerc.d"
4848
path: "/home/vscode/.devcontainer/featurerc.d"
4949
shouldExist: true
5050
permissions: "drwxr-xr-x" # 0755
51-
uid: 1000
52-
gid: 1000
51+
uid: 1001
52+
gid: 1001
5353

5454
- name: "promptrc.d"
5555
path: "/home/vscode/.devcontainer/promptrc.d"
5656
shouldExist: true
5757
permissions: "drwxr-xr-x" # 0755
58-
uid: 1000
59-
gid: 1000
58+
uid: 1001
59+
gid: 1001
6060

6161
fileContentTests:
6262
- name: "zshrc featurerc.d"

0 commit comments

Comments
 (0)