Skip to content

Commit 2d74b46

Browse files
committed
Remove user template variable in base template
It clashes with the user context variable in the user detail view and is unnecessary
1 parent 06daf3c commit 2d74b46

File tree

1 file changed

+5
-7
lines changed

1 file changed

+5
-7
lines changed

controlpanel/frontend/jinja2/base.html

+5-7
Original file line numberDiff line numberDiff line change
@@ -6,8 +6,6 @@
66
{% extends "govuk-frontend.html" %}
77

88
{% set service_name = "Analytical Platform Control Panel" %}
9-
{% set user = {} %}
10-
{% if request %}{% set user = request.user %}{% endif %}
119

1210
{% block page_title %}
1311
{{ page_title }} | {{ service_name }}
@@ -44,7 +42,7 @@
4442
'navigation': [
4543
{
4644
'href': url('index'),
47-
'text': "Signed in as " ~ user.name | default(user.email),
45+
'text': "Signed in as " ~ request.user.name | default(request.user.email),
4846
'active': True
4947
}
5048
]
@@ -56,7 +54,7 @@
5654
{{ navbar({
5755
"items": [
5856
{
59-
"hide": not user.is_superuser,
57+
"hide": not request.user.is_superuser,
6058
"text": "Home",
6159
"href": url("index"),
6260
"active": page_name == "home"
@@ -72,19 +70,19 @@
7270
"active": page_name == "warehouse-datasource-list"
7371
},
7472
{
75-
"hide": not user or not user.userapps.filter(is_admin=True).exists(),
73+
"hide": not request.user or not request.user.userapps.filter(is_admin=True).exists(),
7674
"text": "Webapp data",
7775
"href": url("list-webapp-datasources"),
7876
"active": page_name == "webapp-datasource-list"
7977
},
8078
{
81-
"hide": not user or not user.userapps.filter(is_admin=True).exists(),
79+
"hide": not request.user or not request.user.userapps.filter(is_admin=True).exists(),
8280
"text": "Webapps",
8381
"href": url("list-apps"),
8482
"active": page_name == "webapps"
8583
},
8684
{
87-
"hide": not user.is_superuser,
85+
"hide": not request.user.is_superuser,
8886
"text": "Parameters",
8987
"href": url("list-parameters"),
9088
"active": page_name == "parameters"

0 commit comments

Comments
 (0)