Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CDPT-1211 Update csv upload script #168

Merged
merged 6 commits into from
Jan 23, 2024
Merged

Conversation

njpreddy
Copy link
Contributor

@njpreddy njpreddy commented Jan 23, 2024

Description

As an Office of the Accountant General (OAG)I want to be able to upload a CSV file that now contains 2 new columns. So that I can see these being displayed on the account details page.

The 2 new column headings that will appear on the CSV file will be labelled:

Last Claim Date
Initial dormancy

Validation is required on the following columns:

Case Number should not be null
Year Carried should not be null
Prime Index should not be null
Date Account should not be null

Jira ticket:

https://dsdmoj.atlassian.net/jira/software/c/projects/CDPT/boards/864?assignee=557058%3A2d2f4a33-f427-483f-9c36-338caee60eae&selectedIssue=CDPT-1211

Testing

The application will accept a file containing the new columns and there should be no nulls in the columns listed above. If nulls are found the application renders a 'File is invalid' error.

fum-invalid-file-error

1. Rename the 'cases' table 'dormancy' and 'final claim' date columns.
2. Make all 'cases' table columns except 'Credit Detail' 'not null'.
Copy link
Contributor

@vertism vertism left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@njpreddy njpreddy merged commit 7c4c23e into main Jan 23, 2024
2 checks passed
@njpreddy njpreddy deleted the cdpt-1211-update-csv-upload-script branch January 23, 2024 11:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants