This repository was archived by the owner on May 5, 2020. It is now read-only.
Refactor specs #61
Open
Refactor specs #61
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Looking at the govuk elements site there's a bit of inconsistency in how the HTML should look, but in looking at adding error reporting it looks like the fieldsets should be inside of form-group divs (as shown in the HTML source of https://govuk-elements.herokuapp.com/errors/example-form-validation-single-question-radio).
Styling for errors has been taken from the govuk elements examples here: https://govuk-elements.herokuapp.com/form-elements/example-form-elements/ Some of the example HTML on the above page is inconsistent with HTML given as examples here: https://govuk-elements.herokuapp.com/form-elements/#form-radio-buttons We've aligned with the HTML from the former link because it seems to better support errors. This has meant tweaking some of the non-error HTML, like adding <span> tags around tags in legends. Also fixed some of the HTML generated so that it doesn't get mangled to be "HTML-safe".
This removes checking of generated output against static HTML. This makes specs more focused and more expressive of what they are testing for, and less brittle at the same time.
Put specs for each of check boxes, collection sets and radio buttons into their own spec file to reduce the clutter in the form_builder spec.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is based off of commits in #59 and requires that that PR be merged first.
This is an attempt to make the specs less brittle, and more focused and expressive. It came out of work being done to add error reporting to the form fields that use fieldsets.