Dba 656 #212
Dba 656 #212
Conversation
ranbeersingh1
temporarily deployed
to
development
GitHub Actions
Inactive
ranbeersingh1
temporarily deployed
to
development
GitHub Actions
Inactive
ranbeersingh1
temporarily deployed
to
development
GitHub Actions
Inactive
ranbeersingh1
had a problem deploying
to
delius-core-dev-preapproved
GitHub Actions
Failure
ranbeersingh1
temporarily deployed
to
delius-core-dev-preapproved
GitHub Actions
Inactive
| @@ -135,7 +135,8 @@ jobs: | |||
| environment: ${{needs.build_rman_target_name.outputs.TargetEnvironment}} | |||
| runs-on: ubuntu-latest | |||
| container: | |||
| image: ghcr.io/ministryofjustice/hmpps-delius-operational-automation:0.1 | |||
| image: ghcr.io/ministryofjustice/hmpps-delius-operational-automation:0.40.0 | |||
| options: --user root | |||
There was a problem hiding this comment.
What's the reason for running this job as root? The default ansible user should have all required permissions. If it doesn't we should fix it in the image
There was a problem hiding this comment.
Left over from testing, removed.
docker/delius-ansible-aws/Dockerfile
Outdated
| @@ -21,7 +21,8 @@ LABEL org.opencontainers.image.authors="HMPPS Probation Webops Team (probation-w | |||
| org.opencontainers.image.source="https://github.com/ministryofjustice/hmpps-delius-operational-automation" | |||
|
|
|||
| RUN apk update --no-cache \ | |||
| && apk upgrade --no-cache | |||
| && apk upgrade --no-cache \ | |||
| && apk add gcc musl-dev python3-dev py-setuptools build-base libffi-dev openssl-dev openssh-client git make jq bash curl | |||
There was a problem hiding this comment.
Can you tell me why you want to re-add all of those packages? It feels like we are adding bloat to the image.
If something really is needed we could potentially go for a subset of these?
There was a problem hiding this comment.
Kept only a small number of packages
docker/delius-ansible-aws/Dockerfile
Outdated
| USER ansible | ||
| # USER ansible | ||
|
|
||
| ENTRYPOINT /bin/bash |
There was a problem hiding this comment.
This image is intended to simply be an ansible runner. Because of this, I don't think we should default the entry point to bash. Please correct me if I'm missing something
There was a problem hiding this comment.
Commented out.
ranbeersingh1
temporarily deployed
to
delius-core-dev-preapproved
GitHub Actions
Inactive
ranbeersingh1
temporarily deployed
to
delius-core-dev-preapproved
GitHub Actions
Inactive
ranbeersingh1
temporarily deployed
to
delius-core-dev-preapproved
GitHub Actions
Inactive
ranbeersingh1
temporarily deployed
to
delius-core-dev-preapproved
GitHub Actions
Inactive
No description provided.