Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Dba 828 testing issues #531

Merged
merged 4 commits into from
Feb 21, 2025
Merged

Dba 828 testing issues #531

merged 4 commits into from
Feb 21, 2025

Conversation

dave-belton
Copy link
Contributor

Resolved issues from testing in Test env

@dave-belton
Update playbook.yml
4d598eb 
- tasks are being skipped on Test env so need to see what the output is as the role is PRIMARY
@dave-belton
Update playbook.yml
ffa2791
@dave-belton
DBA-828
5b9ebd5 
- Code block was failing on checks for the objects as multiple recs were being returned by the query
@dave-belton
DBA-828
9da344c 
- fixed setting of fact from get_database_role
- removed invalid param from create_job
@dave-belton dave-belton requested review from a team as code owners February 20, 2025 17:58
ranbeersingh1
ranbeersingh1 approved these changes Feb 21, 2025
View reviewed changes
Copy link
Contributor

@ranbeersingh1 ranbeersingh1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@dave-belton dave-belton merged commit 971bf6f into main Feb 21, 2025
11 checks passed
@dave-belton dave-belton deleted the DBA-828-Testing-Issues branch February 21, 2025 10:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ranbeersingh1 ranbeersingh1 ranbeersingh1 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@dave-belton @ranbeersingh1