Fixing transaction post unit tests

Author: wcdkj

src/main/kotlin/uk/gov/justice/digital/hmpps/hmppsintegrationapi/services/PostTransactionForPersonService.kt

@@ -51,7 +51,7 @@ class PostTransactionForPersonService(
     var response =
       nomisGateway.postTransactionForPerson(
         prisonId,
-        hmppsId,
+        nomisNumber,
         transactionRequest,
       )
 

src/test/kotlin/uk/gov/justice/digital/hmpps/hmppsintegrationapi/gateways/nomis/PostTransactionForPersonTest.kt

@@ -34,9 +34,6 @@ class PostTransactionForPersonTest(
     val nomisApiMockServer = NomisApiMockServer()
     val prisonId = "XYZ"
     val nomisNumber = "AA1234Z"
-    val basePath = "/api/v1/prison/$prisonId/prisoners/$nomisNumber/transactions"
-    val regexPath = "/api/v1/prison/.*/prisoners/.*/transactions"
-
     val description = "Canteen Purchase of £16.34"
     val amount = 1634
     val clientTransactionId = "CL123212"

src/test/kotlin/uk/gov/justice/digital/hmpps/hmppsintegrationapi/services/PostTransactionForPersonServiceTest.kt

@@ -12,6 +12,7 @@ import org.springframework.test.context.bean.override.mockito.MockitoBean
 import uk.gov.justice.digital.hmpps.hmppsintegrationapi.gateways.NomisGateway
 import uk.gov.justice.digital.hmpps.hmppsintegrationapi.models.hmpps.NomisNumber
 import uk.gov.justice.digital.hmpps.hmppsintegrationapi.models.hmpps.Response
+import uk.gov.justice.digital.hmpps.hmppsintegrationapi.models.hmpps.TransactionCreateResponse
 import uk.gov.justice.digital.hmpps.hmppsintegrationapi.models.hmpps.TransactionRequest
 import uk.gov.justice.digital.hmpps.hmppsintegrationapi.models.hmpps.UpstreamApi
 import uk.gov.justice.digital.hmpps.hmppsintegrationapi.models.hmpps.UpstreamApiError
@@ -103,7 +104,7 @@ internal class PostTransactionForPersonServiceTest(
           filters,
         )
 
-      result.data.shouldBe(exampleTransactionResponse)
+      result.data.shouldBe(TransactionCreateResponse(transactionId = exampleTransactionResponse.id))
     }
 
     it("records upstream API errors") {